Skip to content

Commit a5c40d3

Browse files
LHANTAEKcrazywoola
authored andcommitted
Fix: reranker OFF logic to preserve user setting (langgenius#15235)
Co-authored-by: crazywoola <[email protected]>
1 parent ad0b950 commit a5c40d3

File tree

1 file changed

+7
-4
lines changed
  • web/app/components/workflow/nodes/knowledge-retrieval

1 file changed

+7
-4
lines changed

web/app/components/workflow/nodes/knowledge-retrieval/utils.ts

+7-4
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,8 @@ export const getMultipleRetrievalConfig = (
154154
result.reranking_mode = RerankingModeEnum.RerankingModel
155155
if (!result.reranking_model?.provider || !result.reranking_model?.model) {
156156
if (rerankModelIsValid) {
157-
result.reranking_enable = true
157+
result.reranking_enable = reranking_enable !== false
158+
158159
result.reranking_model = {
159160
provider: validRerankModel?.provider || '',
160161
model: validRerankModel?.model || '',
@@ -168,15 +169,16 @@ export const getMultipleRetrievalConfig = (
168169
}
169170
}
170171
else {
171-
result.reranking_enable = true
172+
result.reranking_enable = reranking_enable !== false
172173
}
173174
}
174175

175176
if (allHighQuality && !inconsistentEmbeddingModel && allInternal) {
176177
if (!reranking_mode) {
177178
if (validRerankModel?.provider && validRerankModel?.model) {
178179
result.reranking_mode = RerankingModeEnum.RerankingModel
179-
result.reranking_enable = true
180+
result.reranking_enable = reranking_enable !== false
181+
180182
result.reranking_model = {
181183
provider: validRerankModel.provider,
182184
model: validRerankModel.model,
@@ -194,7 +196,8 @@ export const getMultipleRetrievalConfig = (
194196
if (reranking_mode === RerankingModeEnum.WeightedScore && weights && shouldSetWeightDefaultValue) {
195197
if (rerankModelIsValid) {
196198
result.reranking_mode = RerankingModeEnum.RerankingModel
197-
result.reranking_enable = true
199+
result.reranking_enable = reranking_enable !== false
200+
198201
result.reranking_model = {
199202
provider: validRerankModel.provider || '',
200203
model: validRerankModel.model || '',

0 commit comments

Comments
 (0)