Skip to content

Include mc-schema in bechmarks, It's faster #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mctep opened this issue Jan 25, 2015 · 9 comments
Closed

Include mc-schema in bechmarks, It's faster #76

mctep opened this issue Jan 25, 2015 · 9 comments

Comments

@mctep
Copy link

mctep commented Jan 25, 2015

Hi! Can I take part in the competition #72? :-)

https://github.com/mctep/mc-schema

It passes all tests from https://github.com/json-schema/JSON-Schema-Test-Suite except of:

var IGNORE = [
    'zeroTerminatedFloats.json',
    'refRemote.json',
    'one supplementary Unicode code point is not long enough',
    'two supplementary Unicode code points is long enough'
];
@mctep
Copy link
Author

mctep commented Jan 25, 2015

Forget it. I found some problems :-)

@mctep mctep closed this as completed Jan 25, 2015
@mctep
Copy link
Author

mctep commented Jan 25, 2015

Ok. I can suggest that you use the same schema objects between tests in bencmarks. So modules cans to affect tests between modules (like z-schema). May be you should cloning schema object before setup lib?

@automatthew
Copy link
Contributor

May be you should cloning schema object before setup lib?

Yes, I think this would be a good prophylactic measure

@gilesbowkett
Copy link
Contributor

In an ideal world, I wouldn't mind breaking out the benchmarks into their own repo. As it is, we can make tickets for these suggestions if need be.

@mctep
Copy link
Author

mctep commented Jan 26, 2015

Of course it is up to your up to deside.
I have noticed that you have comments like:

## Disabled because it refuses to accept one of our schema

As for the subject of the issue is-my-json-valid is faster than mc-schema according to your benchmarks. So I closed it.

@automatthew
Copy link
Contributor

@mctep

I have noticed that you have comments like...

I don't want to exclude any reasonable project, but I can't include validators that say a valid document is invalid. Now that we have json-schema-tests, we can better assess problems with other validators and give the authors information on where they're failing.

@automatthew
Copy link
Contributor

As for the subject of the issue is-my-json-valid is faster than mc-schema according to your benchmarks. So I closed it.

Mere speed isn't the only consideration. There are some features that I need in a validator that I would be willing to sacrifice performance to have. I'd like to include your lib in the benchmarks whether or not it's the front-runner.

@mctep
Copy link
Author

mctep commented Jan 27, 2015

Now that we have json-schema-tests

It's a really great idea. I'will keep an eye on. Can I ask you some questions by email about this?

@automatthew
Copy link
Contributor

Can I ask you some questions by email about this?

Yes. My email's in my GitHub profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants