-
Notifications
You must be signed in to change notification settings - Fork 12
Include mc-schema in bechmarks, It's faster #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Forget it. I found some problems :-) |
Ok. I can suggest that you use the same schema objects between tests in bencmarks. So modules cans to affect tests between modules (like z-schema). May be you should cloning schema object before setup lib? |
Yes, I think this would be a good prophylactic measure |
In an ideal world, I wouldn't mind breaking out the benchmarks into their own repo. As it is, we can make tickets for these suggestions if need be. |
Of course it is up to your up to deside.
As for the subject of the issue |
I don't want to exclude any reasonable project, but I can't include validators that say a valid document is invalid. Now that we have json-schema-tests, we can better assess problems with other validators and give the authors information on where they're failing. |
Mere speed isn't the only consideration. There are some features that I need in a validator that I would be willing to sacrifice performance to have. I'd like to include your lib in the benchmarks whether or not it's the front-runner. |
It's a really great idea. I'will keep an eye on. Can I ask you some questions by email about this? |
Yes. My email's in my GitHub profile. |
Hi! Can I take part in the competition #72? :-)
https://github.com/mctep/mc-schema
It passes all tests from https://github.com/json-schema/JSON-Schema-Test-Suite except of:
The text was updated successfully, but these errors were encountered: