Fixes PalisadoesFoundation#3070: tests for Funds/updater.ts (PalisadoesFoundation#3221)

* issue PalisadoesFoundation#3070: tests for Funds/updater.ts

* fix changes

* fix biome issues

* fixes

* type safety fixes

---------

Co-authored-by: Peter Harrison <[email protected]>

Author: Faisalmajeed123

src/graphql/types/Fund/updater.ts

@@ -1,90 +1,95 @@
 import { User } from "~/src/graphql/types/User/User";
 import { TalawaGraphQLError } from "~/src/utilities/TalawaGraphQLError";
+import type { GraphQLContext } from "../../context";
 import { Fund } from "./Fund";
 
-Fund.implement({
-	fields: (t) => ({
-		updater: t.field({
-			description: "User who last updated the fund.",
-			resolve: async (parent, _args, ctx) => {
-				if (!ctx.currentClient.isAuthenticated) {
-					throw new TalawaGraphQLError({
-						extensions: {
-							code: "unauthenticated",
-						},
-					});
-				}
+const authenticateUser = async (ctx: GraphQLContext) => {
+	if (!ctx.currentClient.isAuthenticated) {
+		throw new TalawaGraphQLError({
+			extensions: { code: "unauthenticated" },
+		});
+	}
 
-				const currentUserId = ctx.currentClient.user.id;
+	const currentUserId = ctx.currentClient.user.id;
 
-				const currentUser = await ctx.drizzleClient.query.usersTable.findFirst({
-					with: {
-						organizationMembershipsWhereMember: {
-							columns: {
-								role: true,
-							},
-							where: (fields, operators) =>
-								operators.eq(fields.organizationId, parent.organizationId),
-						},
-					},
-					where: (fields, operators) => operators.eq(fields.id, currentUserId),
-				});
-
-				if (currentUser === undefined) {
-					throw new TalawaGraphQLError({
-						extensions: {
-							code: "unauthenticated",
-						},
-					});
-				}
+	const currentUser = await ctx.drizzleClient.query.usersTable.findFirst({
+		with: {
+			organizationMembershipsWhereMember: {
+				columns: { role: true },
+			},
+		},
+		where: (fields, operators) => operators.eq(fields.id, currentUserId),
+	});
 
-				const currentUserOrganizationMembership =
-					currentUser.organizationMembershipsWhereMember[0];
+	if (currentUser === undefined) {
+		throw new TalawaGraphQLError({
+			extensions: {
+				code: "unauthenticated",
+			},
+		});
+	}
 
-				if (
-					currentUser.role !== "administrator" &&
-					(currentUserOrganizationMembership === undefined ||
-						currentUserOrganizationMembership.role !== "administrator")
-				) {
-					throw new TalawaGraphQLError({
-						extensions: {
-							code: "unauthorized_action",
-						},
-					});
-				}
+	return currentUser;
+};
 
-				if (parent.updaterId === null) {
-					return null;
-				}
+const resolveUpdater = async (
+	parent: Fund,
+	_: unknown,
+	ctx: GraphQLContext,
+) => {
+	const currentUser = await authenticateUser(ctx);
+	const currentUserId = ctx.currentClient.user?.id;
 
-				if (parent.updaterId === currentUserId) {
-					return currentUser;
-				}
+	const currentUserOrganizationMembership =
+		currentUser.organizationMembershipsWhereMember?.[0];
 
-				const updaterId = parent.updaterId;
+	if (
+		currentUser.role !== "administrator" &&
+		(currentUserOrganizationMembership === undefined ||
+			currentUserOrganizationMembership.role !== "administrator")
+	) {
+		throw new TalawaGraphQLError({
+			extensions: {
+				code: "unauthorized_action",
+			},
+		});
+	}
 
-				const existingUser = await ctx.drizzleClient.query.usersTable.findFirst(
-					{
-						where: (fields, operators) => operators.eq(fields.id, updaterId),
-					},
-				);
+	if (parent.updaterId === null) {
+		return null;
+	}
+	if (parent.updaterId === currentUserId) {
+		return currentUser;
+	}
 
-				// Updater id existing but the associated user not existing is a business logic error and probably means that the corresponding data in the database is in a corrupted state. It must be investigated and fixed as soon as possible to prevent additional data corruption.
-				if (existingUser === undefined) {
-					ctx.log.error(
-						"Postgres select operation returned an empty array for a fund's updater id that isn't null.",
-					);
+	const updaterId = parent.updaterId;
 
-					throw new TalawaGraphQLError({
-						extensions: {
-							code: "unexpected",
-						},
-					});
-				}
+	const existingUser = await ctx.drizzleClient.query.usersTable.findFirst({
+		where: (fields, operators) => operators.eq(fields.id, updaterId),
+	});
 
-				return existingUser;
+	if (existingUser === undefined) {
+		ctx.log.error(
+			"Postgres select operation returned an empty array for a fund's updater id that isn't null.",
+		);
+		throw new TalawaGraphQLError({
+			extensions: {
+				code: "unexpected",
 			},
+		});
+	}
+
+	return existingUser;
+};
+
+Fund.implement({
+	fields: (t) => ({
+		updater: t.field({
+			description: "User who last updated the fund.",
+			resolve: resolveUpdater,
 			type: User,
 		}),
 	}),
 });
+
+export { resolveUpdater };