-
Notifications
You must be signed in to change notification settings - Fork 41
Tests do not pass on 1.2 branch of julia #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This test seems to be failing because of the way random matrices are generated changed. If yes, we could just hardcode the problem data instead of randomly generating it. |
Yes. I am personally not 100% sure what the exact policy is regarding backwards compatibility of the random number streams. I know at least that they won't be changed in new patch versions of Julia. Best if possible not to rely on the exact random numbers of course. |
I removed the test problem since it was redundant anyway. 660fb7f |
While running tests on all package for the upcoming Julia 1.2 release, this package started failing with the error:
The cause of failure was bisected to the PR JuliaLang/julia#30494 which improved the performance of random numbers for sparse matrices but also changed the exact numbers that got generated.
The text was updated successfully, but these errors were encountered: