Skip to content

Tests do not pass on 1.2 branch of julia #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KristofferC opened this issue May 16, 2019 · 3 comments
Closed

Tests do not pass on 1.2 branch of julia #83

KristofferC opened this issue May 16, 2019 · 3 comments

Comments

@KristofferC
Copy link

While running tests on all package for the upcoming Julia 1.2 release, this package started failing with the error:

QP - Lasso: Test Failed at /root/.julia/packages/COSMO/7ALGG/test/UnitTests/qp-lasso.jl:42
  Expression: isapprox(res.obj_val, 46.40521553063313, atol=0.001)
   Evaluated: isapprox(45.609486486081586, 46.40521553063313; atol=0.001)

The cause of failure was bisected to the PR JuliaLang/julia#30494 which improved the performance of random numbers for sparse matrices but also changed the exact numbers that got generated.

@migarstka
Copy link
Member

This test seems to be failing because of the way random matrices are generated changed.
Will this change to the random number stream be kept in Julia v1.2?

If yes, we could just hardcode the problem data instead of randomly generating it.

@KristofferC
Copy link
Author

KristofferC commented May 16, 2019

This test seems to be failing because of the way random matrices are generated changed.

Yes.

I am personally not 100% sure what the exact policy is regarding backwards compatibility of the random number streams. I know at least that they won't be changed in new patch versions of Julia. Best if possible not to rely on the exact random numbers of course.

@migarstka
Copy link
Member

I removed the test problem since it was redundant anyway. 660fb7f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants