-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Regex doesn't handle beginnings in backtracing #5288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Found the issue. It's a combination of back/forward tracing and the start/end symbols. The following code produces correct results until this is fixed: let reviewers = `,${frontMatter.attributes.author},`?.match(/(?<=(?:^|,)[^<(]+\(@)(.*?)(?=\)\s*(<(("[^"]+")|([\w.]+)@[\w.]+)>)?(?:$|,))/g) || []; |
This might be fixed by #5167. @dylan-conway want to check? |
If it is, would it be possible to release a version 1.0.2 sooner rather than later? |
Unfortunately this is a bug in JSC and #5167 does not fix it. |
This has been fixed in the latest version of safari. We will have this bug fix when we upgrade our WebKit fork |
When will that be? |
fixed in v1.0.3 |
What version of Bun is running?
1.0.1+31aec4ebe325982fc0ef27498984b0ad9969162b
What platform is your computer?
Linux 5.15.90.1-microsoft-standard-WSL2 x86_64 unknown
What steps can reproduce the bug?
I was originally using NodeJS for my project. I have the following regex to extract github usernames from an author string:
What is the expected behavior?
In NodeJS:
What do you see instead?
In Bun:
Additional information
No response
The text was updated successfully, but these errors were encountered: