New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bad copy paste #2884

Open

Bbulatov opened this issue Feb 27, 2025 · 2 comments

Bbulatov commented Feb 27, 2025

Hello!
During the static analysis was found possible mistake in code:

There is using 'LS_NLRI_TYPE_PREFIX_IPV4' in pkg/packet/bgp/bgp.go:9146, but case is using 'LS_NLRI_TYPE_PREFIX_IPV6'. Please, clarify, why is using value 'LS_NLRI_TYPE_PREFIX_IPV4'? Might be there should be 'LS_NLRI_TYPE_PREFIX_IPV6' instead of 'LS_NLRI_TYPE_PREFIX_IPV4'?

Member

fujita commented Feb 28, 2025

Looks like so.

Author

Bbulatov commented Mar 3, 2025

Please clarify whether this requires changes? Or does it not affect the work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment