fix: navigation bar blocked out the virtual keyboard (again)

Author: WhiredPlanck

app/src/main/java/com/osfans/trime/ime/composition/CandidatesView.kt

@@ -7,10 +7,12 @@ package com.osfans.trime.ime.composition
 
 import android.annotation.SuppressLint
 import android.graphics.RectF
+import android.os.Build
 import android.view.View
 import android.view.ViewGroup
 import android.view.ViewTreeObserver.OnGlobalLayoutListener
 import android.view.ViewTreeObserver.OnPreDrawListener
+import android.view.WindowInsets
 import androidx.annotation.Size
 import androidx.core.graphics.component1
 import androidx.core.graphics.component2
@@ -24,7 +26,7 @@ import com.osfans.trime.data.prefs.AppPrefs
 import com.osfans.trime.data.theme.ColorManager
 import com.osfans.trime.data.theme.Theme
 import com.osfans.trime.ime.candidates.popup.PagedCandidatesUi
-import com.osfans.trime.ime.core.BaseInputMessenger
+import com.osfans.trime.ime.core.BaseInputView
 import com.osfans.trime.ime.core.TouchEventReceiverWindow
 import com.osfans.trime.ime.core.TrimeInputMethodService
 import splitties.dimensions.dp
@@ -48,7 +50,7 @@ class CandidatesView(
     service: TrimeInputMethodService,
     rime: RimeSession,
     theme: Theme,
-) : BaseInputMessenger(service, rime, theme) {
+) : BaseInputView(service, rime, theme) {
     private val ctx = context.withTheme(android.R.style.Theme_DeviceDefault_Settings)
 
     private val position by AppPrefs.defaultInstance().candidates.position
@@ -102,6 +104,8 @@ class CandidatesView(
 
     private val touchEventReceiverWindow = TouchEventReceiverWindow(this)
 
+    private var bottomInsets = 0
+
     override fun handleRimeMessage(it: RimeMessage<*>) {
         if (it is RimeMessage.ResponseMessage) {
             inputComposition = it.data.context.composition
@@ -175,7 +179,8 @@ class CandidatesView(
                     } else {
                         if (horizontal + selfWidth > parentWidth) parentWidth - selfWidth else horizontal
                     }
-                y = if (bottom + selfHeight > parentHeight) top - selfHeight else bottom
+                val bottomLimit = parentHeight - bottomInsets
+                y = if (bottom + selfHeight > bottomLimit) top - selfHeight else bottom
             }
         }
         translationX = x
@@ -232,6 +237,13 @@ class CandidatesView(
         layoutParams = ViewGroup.LayoutParams(wrapContent, wrapContent)
     }
 
+    override fun onApplyWindowInsets(insets: WindowInsets): WindowInsets {
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM) {
+            bottomInsets = getNavBarBottomInset(insets)
+        }
+        return insets
+    }
+
     override fun onAttachedToWindow() {
         super.onAttachedToWindow()
         candidatesUi.root.viewTreeObserver.addOnGlobalLayoutListener(layoutListener)

app/src/main/java/com/osfans/trime/ime/core/BaseInputMessenger.kt

@@ -0,0 +1,97 @@
+/*
+ * SPDX-FileCopyrightText: 2015 - 2025 Rime community
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+package com.osfans.trime.ime.core
+
+import android.annotation.SuppressLint
+import android.content.res.Resources
+import android.view.WindowInsets
+import androidx.constraintlayout.widget.ConstraintLayout
+import androidx.core.view.WindowInsetsCompat
+import androidx.lifecycle.lifecycleScope
+import com.osfans.trime.core.RimeMessage
+import com.osfans.trime.daemon.RimeSession
+import com.osfans.trime.data.theme.Theme
+import com.osfans.trime.data.theme.ThemeManager
+import com.osfans.trime.data.theme.ThemePrefs
+import kotlinx.coroutines.Job
+import kotlinx.coroutines.launch
+import splitties.dimensions.dp
+import kotlin.math.max
+
+abstract class BaseInputView(
+    val service: TrimeInputMethodService,
+    val rime: RimeSession,
+    val theme: Theme,
+) : ConstraintLayout(service) {
+    protected abstract fun handleRimeMessage(it: RimeMessage<*>)
+
+    private var messageHandlerJob: Job? = null
+
+    private fun setupRimeMessageHandler() {
+        messageHandlerJob =
+            service.lifecycleScope.launch {
+                rime.run { messageFlow }.collect {
+                    handleRimeMessage(it)
+                }
+            }
+    }
+
+    var handleMessages = false
+        set(value) {
+            field = value
+            if (field) {
+                if (messageHandlerJob == null) {
+                    setupRimeMessageHandler()
+                }
+            } else {
+                messageHandlerJob?.cancel()
+                messageHandlerJob = null
+            }
+        }
+
+    private val navBarBackground by ThemeManager.prefs.navbarBackground
+
+    private val navBarFrameHeight: Int
+        get() {
+            @SuppressLint("DiscouragedApi")
+            val resId = resources.getIdentifier("navigation_bar_frame_height", "dimen", "android")
+            return try {
+                resources.getDimensionPixelSize(resId)
+            } catch (e: Resources.NotFoundException) {
+                dp(FALLBACK_NAVBAR_HEIGHT)
+            }
+        }
+
+    protected fun getNavBarBottomInset(windowInsets: WindowInsets): Int {
+        if (navBarBackground != ThemePrefs.NavbarBackground.FULL) {
+            return 0
+        }
+        val insets = WindowInsetsCompat.toWindowInsetsCompat(windowInsets)
+        // use navigation bar insets when available
+        val navBars = insets.getInsets(WindowInsetsCompat.Type.navigationBars())
+        // in case navigation bar insets goes wrong (eg. on LineageOS 21+ with gesture navigation)
+        // use mandatory system gesture insets
+        val mandatory = insets.getInsets(WindowInsetsCompat.Type.mandatorySystemGestures())
+        var insetsBottom = max(navBars.bottom, mandatory.bottom)
+        if (insetsBottom <= 0) {
+            // check system gesture insets and fallback to navigation_bar_frame_height just in case
+            val gesturesBottom = insets.getInsets(WindowInsetsCompat.Type.systemGestures()).bottom
+            if (gesturesBottom > 0) {
+                insetsBottom = max(gesturesBottom, navBarFrameHeight)
+            }
+        }
+        return insetsBottom
+    }
+
+    override fun onDetachedFromWindow() {
+        handleMessages = false
+        super.onDetachedFromWindow()
+    }
+
+    companion object {
+        private const val FALLBACK_NAVBAR_HEIGHT = 48
+    }
+}

app/src/main/java/com/osfans/trime/ime/core/BaseInputView.kt

@@ -7,6 +7,7 @@ package com.osfans.trime.ime.core
 import android.annotation.SuppressLint
 import android.view.View
 import android.view.View.OnClickListener
+import android.view.WindowInsets
 import android.view.inputmethod.EditorInfo
 import android.widget.ImageView
 import androidx.core.content.ContextCompat
@@ -58,7 +59,7 @@ class InputView(
     service: TrimeInputMethodService,
     rime: RimeSession,
     theme: Theme,
-) : BaseInputMessenger(service, rime, theme) {
+) : BaseInputView(service, rime, theme) {
     private val keyboardBackground =
         imageView {
             scaleType = ImageView.ScaleType.CENTER_CROP
@@ -254,6 +255,13 @@ class InputView(
         quickBar.view.setPadding(sidePadding, 0, sidePadding, 0)
     }
 
+    override fun onApplyWindowInsets(insets: WindowInsets): WindowInsets {
+        bottomPaddingSpace.updateLayoutParams<LayoutParams> {
+            bottomMargin = getNavBarBottomInset(insets)
+        }
+        return insets
+    }
+
     fun startInput(
         info: EditorInfo,
         restarting: Boolean = false,

app/src/main/java/com/osfans/trime/ime/core/InputView.kt

@@ -101,7 +101,7 @@ class NavigationBarManager {
         }
     }
 
-    fun setupInputView(v: BaseInputMessenger) {
+    fun setupInputView(v: BaseInputView) {
         // on API 35+, we must call requestApplyInsets() manually after replacing views,
         // otherwise View#onApplyWindowInsets won't be called. ¯\_(ツ)_/¯
         v.requestApplyInsets()

app/src/main/java/com/osfans/trime/ime/core/NavigationBarManager.kt

@@ -306,7 +306,6 @@ open class TrimeInputMethodService : LifecycleInputMethodService() {
 
     private fun replaceInputViews(theme: Theme) {
         navBarManager.evaluate(window.window!!)
-        navBarManager.update(window.window!!)
         replaceInputView(theme)
         replaceCandidateView(theme)
     }