Skip to content

fix(script): --ignore flag was not working properly for all scenarios #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2021

Conversation

oscard0m
Copy link
Owner

πŸ“ Summary

  • --ignore flag is being applied properly when there is an existing subscription for a repository

β›± Motivation and Context

When running --ignore flag for already subscribed repositories was entering in a condition where it was not doing anything.

These are the scenarios where the command should skip:

isSubscribed isIgnored isUnsubscribed
subscribe πŸ›‘ βœ… βœ…
unwatch βœ… βœ… πŸ›‘
ignore βœ… πŸ›‘ βœ…

Fix #3

@oscard0m oscard0m added the bug Something isn't working label May 18, 2021
@oscard0m oscard0m merged commit a5f8897 into main May 18, 2021
@oscard0m oscard0m deleted the fix-ignore-flag branch May 18, 2021 17:41
@github-actions
Copy link

πŸŽ‰ This PR is included in version 2.0.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--ignore flag is not working
1 participant