fix: return browser to 'return_to' when logging in without registered account using oidc. #2496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2496 +/- ##
==========================================
+ Coverage 75.21% 75.32% +0.10%
==========================================
Files 295 295
Lines 16379 16386 +7
==========================================
+ Hits 12320 12343 +23
+ Misses 3116 3102 -14
+ Partials 943 941 -2
|
Urbansson
changed the title
aeneasr
force-pushed
the
oidc-redirect-to-return-to
branch
from
9928e7f to
23565ab
Compare
aeneasr
previously approved these changes
Jul 19, 2022
aeneasr
force-pushed
the
oidc-redirect-to-return-to
branch
from
f637cdf to
c74a815
Compare
|
Nice work! LGTM 🚀! |
…ration using oidc.
aeneasr
force-pushed
the
oidc-redirect-to-return-to
branch
from
d289b85 to
982854b
Compare
gi0baro
pushed a commit
to casavo/kratos
that referenced
this pull request
Nov 18, 2022
… account using oidc. (ory#2496) Close ory#2444 Co-authored-by: aeneasr <[email protected]>
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
… account using oidc. (ory#2496) Close ory#2444 Co-authored-by: aeneasr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling the callback from the oidc provider and starting a new registration flow to sign up the user we create a new temp request that contains the initial request parameters from the login flow.
Related issue(s)
Proposal to close #2444.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments