fix: unable to find JSON Schema ID: default (#2393)

Author: splaunov

identity/manager.go

@@ -4,6 +4,8 @@ import (
 	"context"
 	"reflect"
 
+	"github.com/ory/kratos/driver/config"
+
 	"github.com/gofrs/uuid"
 
 	"github.com/mohae/deepcopy"
@@ -21,6 +23,7 @@ var ErrProtectedFieldModified = herodot.ErrForbidden.
 
 type (
 	managerDependencies interface {
+		config.Provider
 		PoolProvider
 		courier.Provider
 		ValidationProvider
@@ -62,6 +65,10 @@ func newManagerOptions(opts []ManagerOption) *managerOptions {
 }
 
 func (m *Manager) Create(ctx context.Context, i *Identity, opts ...ManagerOption) error {
+	if i.SchemaID == "" {
+		i.SchemaID = m.r.Config(ctx).DefaultIdentityTraitsSchemaID()
+	}
+
 	o := newManagerOptions(opts)
 	if err := m.validate(ctx, i, o); err != nil {
 		return err

identity/manager_test.go

@@ -4,6 +4,9 @@ import (
 	"context"
 	"fmt"
 	"testing"
+	"time"
+
+	"github.com/ory/x/sqlxx"
 
 	"github.com/ory/kratos/internal/testhelpers"
 
@@ -250,3 +253,23 @@ func TestManager(t *testing.T) {
 		})
 	})
 }
+
+func TestManagerNoDefaultNamedSchema(t *testing.T) {
+	conf, reg := internal.NewFastRegistryWithMocks(t)
+	conf.MustSet(config.ViperKeyDefaultIdentitySchemaID, "user_v0")
+	conf.MustSet(config.ViperKeyIdentitySchemas, config.Schemas{
+		{ID: "user_v0", URL: "file://./stub/manager.schema.json"},
+	})
+	conf.MustSet(config.ViperKeyPublicBaseURL, "https://www.ory.sh/")
+
+	t.Run("case=should create identity with default schema", func(t *testing.T) {
+		stateChangedAt := sqlxx.NullTime(time.Now().UTC())
+		original := &identity.Identity{
+			SchemaID:       "",
+			Traits:         []byte(identity.Traits(`{"email":"[email protected]"}`)),
+			State:          identity.StateActive,
+			StateChangedAt: &stateChangedAt,
+		}
+		require.NoError(t, reg.IdentityManager().Create(context.Background(), original))
+	})
+}