Skip to content

Commit d469d5d

Browse files
committed
Fix bazel coverage build on Jenkins
Summary: Coverage runs were getting `nobuild_runfile_links` from a expansion of `remote_download_minimal`. This happens to cause issues. So explicitly set `build_runfile_links` for coverage runs. See bazelbuild/bazel#4685 (comment) Test Plan: Ran the coverage build, most of the failures go away. Reviewers: zasgar, michelle, jamesbartlett Reviewed By: jamesbartlett Signed-off-by: Vihang Mehta <[email protected]> Differential Revision: https://phab.corp.pixielabs.ai/D11654
1 parent 15ba5c7 commit d469d5d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.bazelrc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ build --host_action_env=CLANG_COMPILER_VERSION=14.0_0
77
build --remote_download_minimal
88
test --remote_download_minimal
99
run --remote_download_toplevel
10+
coverage --build_runfile_links
1011

1112
build:clang --action_env=CC
1213
build:clang --host_action_env=CC
@@ -202,8 +203,6 @@ coverage --instrument_test_targets
202203
coverage --define PL_COVERAGE=true
203204
coverage --copt -DPL_COVERAGE
204205
coverage --test_tag_filters=-requires_root,-requires_bpf,-no_coverage,-disabled,-no_gcc
205-
# Uploading to BES from the coverage build seems to fail on jenkins.
206-
coverage --experimental_build_event_upload_strategy=local
207206

208207
# Use stable GIT build tag by default.
209208
build --define BUNDLE_VERSION={STABLE_BUILD_TAG}

ci/jenkins.bazelrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,6 @@ test --local_cpu_resources=14
4444

4545
build --jobs 16
4646
test --jobs 16
47+
48+
# Uploading to BES from the coverage build seems to fail on jenkins.
49+
coverage --experimental_build_event_upload_strategy=local

0 commit comments

Comments
 (0)