Skip to content

Commit c48c56a

Browse files
disable tests
1 parent d925667 commit c48c56a

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

server/src/main/java/org/elasticsearch/action/search/CanMatchPreFilterSearchPhase.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,12 @@ private void runCoordinatorRewritePhase() {
167167
if (matchedShardLevelRequests.isEmpty()) {
168168
finishPhase();
169169
} else {
170+
// verify missing shards only for the shards that we hit for the query
171+
checkNoMissingShards(matchedShardLevelRequests);
170172
if (SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG) {
171173
matchedShardLevelRequests.sort(SearchShardIterator::compareTo);
172174
listener.onResponse(matchedShardLevelRequests);
173175
} else {
174-
// verify missing shards only for the shards that we hit for the query
175-
checkNoMissingShards(matchedShardLevelRequests);
176176
new Round(matchedShardLevelRequests).run();
177177
}
178178
}

server/src/test/java/org/elasticsearch/action/search/CanMatchPreFilterSearchPhaseTests.java

+19-1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
import org.elasticsearch.index.shard.ShardLongFieldRange;
4444
import org.elasticsearch.indices.DateFieldRangeInfo;
4545
import org.elasticsearch.search.CanMatchShardResponse;
46+
import org.elasticsearch.search.SearchService;
4647
import org.elasticsearch.search.aggregations.AggregationBuilder;
4748
import org.elasticsearch.search.aggregations.bucket.terms.SignificantTermsAggregationBuilder;
4849
import org.elasticsearch.search.builder.SearchSourceBuilder;
@@ -101,7 +102,7 @@ public void tearDown() throws Exception {
101102
}
102103

103104
public void testFilterShards() throws InterruptedException {
104-
105+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
105106
final TransportSearchAction.SearchTimeProvider timeProvider = new TransportSearchAction.SearchTimeProvider(
106107
0,
107108
System.nanoTime(),
@@ -188,6 +189,8 @@ public void sendCanMatch(
188189
}
189190

190191
public void testFilterWithFailure() throws InterruptedException {
192+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
193+
191194
final TransportSearchAction.SearchTimeProvider timeProvider = new TransportSearchAction.SearchTimeProvider(
192195
0,
193196
System.nanoTime(),
@@ -279,6 +282,8 @@ public void sendCanMatch(
279282
}
280283

281284
public void testSortShards() throws InterruptedException {
285+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
286+
282287
final TransportSearchAction.SearchTimeProvider timeProvider = new TransportSearchAction.SearchTimeProvider(
283288
0,
284289
System.nanoTime(),
@@ -640,6 +645,7 @@ public void doCanMatchFilteringOnCoordinatorThatCanBeSkipped(String timestampFie
640645
}
641646

642647
public void testCoordinatorCanMatchFilteringThatCanBeSkippedUsingBothTimestamps() throws Exception {
648+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
643649
Index dataStreamIndex1 = new Index(".ds-twoTimestamps0001", UUIDs.base64UUID());
644650
Index dataStreamIndex2 = new Index(".ds-twoTimestamps0002", UUIDs.base64UUID());
645651
DataStream dataStream = DataStreamTestHelper.newInstance("mydata", List.of(dataStreamIndex1, dataStreamIndex2));
@@ -724,6 +730,8 @@ public void testCoordinatorCanMatchFilteringThatCanBeSkippedUsingBothTimestamps(
724730
}
725731

726732
public void testCanMatchFilteringOnCoordinatorParsingFails() throws Exception {
733+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
734+
727735
Index dataStreamIndex1 = new Index(".ds-mydata0001", UUIDs.base64UUID());
728736
Index dataStreamIndex2 = new Index(".ds-mydata0002", UUIDs.base64UUID());
729737
DataStream dataStream = DataStreamTestHelper.newInstance("mydata", List.of(dataStreamIndex1, dataStreamIndex2));
@@ -763,6 +771,8 @@ public void testCanMatchFilteringOnCoordinatorParsingFails() throws Exception {
763771
}
764772

765773
public void testCanMatchFilteringOnCoordinatorThatCanNotBeSkipped() throws Exception {
774+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
775+
766776
// Generate indices
767777
Index dataStreamIndex1 = new Index(".ds-mydata0001", UUIDs.base64UUID());
768778
Index dataStreamIndex2 = new Index(".ds-mydata0002", UUIDs.base64UUID());
@@ -817,6 +827,7 @@ public void testCanMatchFilteringOnCoordinatorThatCanNotBeSkipped() throws Excep
817827
}
818828

819829
public void testCanMatchFilteringOnCoordinatorWithTimestampAndEventIngestedThatCanNotBeSkipped() throws Exception {
830+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
820831
// Generate indices
821832
Index dataStreamIndex1 = new Index(".ds-mydata0001", UUIDs.base64UUID());
822833
Index dataStreamIndex2 = new Index(".ds-mydata0002", UUIDs.base64UUID());
@@ -884,6 +895,8 @@ public void testCanMatchFilteringOnCoordinatorWithTimestampAndEventIngestedThatC
884895
}
885896

886897
public void testCanMatchFilteringOnCoordinator_withSignificantTermsAggregation_withDefaultBackgroundFilter() throws Exception {
898+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
899+
887900
Index index1 = new Index("index1", UUIDs.base64UUID());
888901
Index index2 = new Index("index2", UUIDs.base64UUID());
889902
Index index3 = new Index("index3", UUIDs.base64UUID());
@@ -951,6 +964,8 @@ public void testCanMatchFilteringOnCoordinator_withSignificantTermsAggregation_w
951964
}
952965

953966
public void testCanMatchFilteringOnCoordinator_withSignificantTermsAggregation_withSuggest() throws Exception {
967+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
968+
954969
Index index1 = new Index("index1", UUIDs.base64UUID());
955970
Index index2 = new Index("index2", UUIDs.base64UUID());
956971
Index index3 = new Index("index3", UUIDs.base64UUID());
@@ -981,6 +996,8 @@ public void testCanMatchFilteringOnCoordinator_withSignificantTermsAggregation_w
981996
}
982997

983998
public void testCanMatchFilteringOnCoordinator_withSignificantTermsAggregation_withSuggest_withTwoTimestamps() throws Exception {
999+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
1000+
9841001
Index index1 = new Index("index1", UUIDs.base64UUID());
9851002
Index index2 = new Index("index2", UUIDs.base64UUID());
9861003
Index index3 = new Index("index3", UUIDs.base64UUID());
@@ -1018,6 +1035,7 @@ public void testCanMatchFilteringOnCoordinator_withSignificantTermsAggregation_w
10181035
}
10191036

10201037
public void testCanMatchFilteringOnCoordinatorThatCanBeSkippedTsdb() throws Exception {
1038+
assumeFalse("no actual can_match if batched execution is active", SearchService.BATCHED_QUERY_PHASE_FEATURE_FLAG);
10211039
DataStream dataStream1;
10221040
{
10231041
Index index1 = new Index(".ds-ds10001", UUIDs.base64UUID());

0 commit comments

Comments
 (0)