Minor cleanup Aggregations Module

Just some random finds of unused code from researching memory things.

Author: original-brownbear

modules/aggregations/src/main/java/org/elasticsearch/aggregations/bucket/adjacency/AdjacencyMatrixAggregationBuilder.java

@@ -173,13 +173,6 @@ public AdjacencyMatrixAggregationBuilder separator(String separator) {
         return this;
     }
 
-    /**
-     * Get the separator used to join pairs of bucket keys
-     */
-    public String separator() {
-        return separator;
-    }
-
     /**
      * Get the filters. This will be an unmodifiable map
      */

modules/aggregations/src/main/java/org/elasticsearch/aggregations/bucket/adjacency/InternalAdjacencyMatrix.java

@@ -35,7 +35,7 @@ public class InternalAdjacencyMatrix extends InternalMultiBucketAggregation<Inte
     public static class InternalBucket extends InternalMultiBucketAggregation.InternalBucket implements AdjacencyMatrix.Bucket {
 
         private final String key;
-        private long docCount;
+        private final long docCount;
         InternalAggregations aggregations;
 
         public InternalBucket(String key, long docCount, InternalAggregations aggregations) {

modules/aggregations/src/main/java/org/elasticsearch/aggregations/bucket/histogram/AutoDateHistogramAggregationBuilder.java

@@ -188,10 +188,6 @@ public AutoDateHistogramAggregationBuilder setNumBuckets(int numBuckets) {
         return this;
     }
 
-    public int getNumBuckets() {
-        return numBuckets;
-    }
-
     @Override
     public BucketCardinality bucketCardinality() {
         return BucketCardinality.MANY;
@@ -236,8 +232,7 @@ static Rounding createRounding(Rounding.DateTimeUnit interval, ZoneId timeZone)
         if (timeZone != null) {
             tzRoundingBuilder.timeZone(timeZone);
         }
-        Rounding rounding = tzRoundingBuilder.build();
-        return rounding;
+        return tzRoundingBuilder.build();
     }
 
     @Override

modules/aggregations/src/main/java/org/elasticsearch/aggregations/bucket/histogram/AutoDateHistogramAggregator.java

@@ -231,7 +231,7 @@ private static class FromSingle extends AutoDateHistogramAggregator {
         }
 
         @Override
-        protected LeafBucketCollector getLeafCollector(SortedNumericDocValues values, LeafBucketCollector sub) throws IOException {
+        protected LeafBucketCollector getLeafCollector(SortedNumericDocValues values, LeafBucketCollector sub) {
             return new LeafBucketCollectorBase(sub, values) {
                 @Override
                 public void collect(int doc, long owningBucketOrd) throws IOException {
@@ -441,7 +441,7 @@ private static class FromMany extends AutoDateHistogramAggregator {
         }
 
         @Override
-        protected LeafBucketCollector getLeafCollector(SortedNumericDocValues values, LeafBucketCollector sub) throws IOException {
+        protected LeafBucketCollector getLeafCollector(SortedNumericDocValues values, LeafBucketCollector sub) {
             return new LeafBucketCollectorBase(sub, values) {
                 @Override
                 public void collect(int doc, long owningBucketOrd) throws IOException {

modules/aggregations/src/main/java/org/elasticsearch/aggregations/bucket/histogram/InternalAutoDateHistogram.java

@@ -134,10 +134,6 @@ public int compareKey(Bucket other) {
             return Long.compare(key, other.key);
         }
 
-        public DocValueFormat getFormatter() {
-            return format;
-        }
-
         Bucket finalizeSampling(SamplingContext samplingContext) {
             return new Bucket(
                 key,
@@ -279,7 +275,7 @@ public int getTargetBuckets() {
         return targetBuckets;
     }
 
-    public BucketInfo getBucketInfo() {
+    BucketInfo getBucketInfo() {
         return bucketInfo;
     }
 

modules/aggregations/src/main/java/org/elasticsearch/aggregations/bucket/timeseries/TimeSeriesAggregationBuilder.java

@@ -35,7 +35,7 @@ public class TimeSeriesAggregationBuilder extends AbstractAggregationBuilder<Tim
     public static final ParseField SIZE_FIELD = new ParseField("size");
     public static final InstantiatingObjectParser<TimeSeriesAggregationBuilder, String> PARSER;
 
-    private boolean keyed;
+    private final boolean keyed;
     private int size;
 
     private static final int DEFAULT_SIZE = MultiBucketConsumerService.DEFAULT_MAX_BUCKETS;
@@ -126,14 +126,6 @@ public boolean isInSortOrderExecutionRequired() {
         return true;
     }
 
-    public boolean isKeyed() {
-        return keyed;
-    }
-
-    public void setKeyed(boolean keyed) {
-        this.keyed = keyed;
-    }
-
     public TimeSeriesAggregationBuilder setSize(int size) {
         if (size <= 0) {
             throw new IllegalArgumentException("[size] must be greater than 0. Found [" + size + "] in [" + name + "]");