Delete unused response-deserialization code

With the transport client gone, lots of these constructors have become
unused. Removing this dead code also allows making a lot of fields final
as an added bonus.

Author: original-brownbear

modules/lang-mustache/src/main/java/org/elasticsearch/script/mustache/MultiSearchTemplateResponse.java

@@ -14,7 +14,6 @@
 import org.elasticsearch.action.ActionResponse;
 import org.elasticsearch.common.Strings;
 import org.elasticsearch.common.collect.Iterators;
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.common.io.stream.Writeable;
 import org.elasticsearch.core.AbstractRefCounted;
@@ -38,16 +37,6 @@ public static class Item implements Writeable {
         private final SearchTemplateResponse response;
         private final Exception exception;
 
-        private Item(StreamInput in) throws IOException {
-            if (in.readBoolean()) {
-                this.response = new SearchTemplateResponse(in);
-                this.exception = null;
-            } else {
-                exception = in.readException();
-                this.response = null;
-            }
-        }
-
         public Item(SearchTemplateResponse response, Exception exception) {
             this.response = response;
             this.exception = exception;
@@ -114,16 +103,6 @@ protected void closeInternal() {
         }
     });
 
-    MultiSearchTemplateResponse(StreamInput in) throws IOException {
-        super(in);
-        items = in.readArray(Item::new, Item[]::new);
-        if (in.getTransportVersion().onOrAfter(TransportVersions.V_7_0_0)) {
-            tookInMillis = in.readVLong();
-        } else {
-            tookInMillis = -1L;
-        }
-    }
-
     MultiSearchTemplateResponse(Item[] items, long tookInMillis) {
         this.items = items;
         this.tookInMillis = tookInMillis;

modules/lang-mustache/src/main/java/org/elasticsearch/script/mustache/SearchTemplateResponse.java

@@ -11,7 +11,6 @@
 import org.elasticsearch.action.ActionResponse;
 import org.elasticsearch.action.search.SearchResponse;
 import org.elasticsearch.common.bytes.BytesReference;
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.common.xcontent.ChunkedToXContent;
 import org.elasticsearch.core.AbstractRefCounted;
@@ -46,12 +45,6 @@ protected void closeInternal() {
 
     SearchTemplateResponse() {}
 
-    SearchTemplateResponse(StreamInput in) throws IOException {
-        super(in);
-        source = in.readOptionalBytesReference();
-        response = in.readOptionalWriteable(SearchResponse::new);
-    }
-
     public BytesReference getSource() {
         return source;
     }

modules/lang-painless/src/main/java/org/elasticsearch/painless/action/PainlessContextAction.java

@@ -108,12 +108,6 @@ public Response(List<String> scriptContextNames, PainlessContextInfo painlessCon
             this.painlessContextInfo = painlessContextInfo;
         }
 
-        public Response(StreamInput in) throws IOException {
-            super(in);
-            scriptContextNames = in.readStringCollectionAsList();
-            painlessContextInfo = in.readOptionalWriteable(PainlessContextInfo::new);
-        }
-
         @Override
         public void writeTo(StreamOutput out) throws IOException {
             out.writeStringCollection(scriptContextNames);

modules/lang-painless/src/main/java/org/elasticsearch/painless/action/PainlessExecuteAction.java

@@ -462,7 +462,7 @@ static boolean needDocumentAndIndex(ScriptContext<?> scriptContext) {
 
     public static class Response extends ActionResponse implements ToXContentObject {
 
-        private Object result;
+        private final Object result;
 
         Response(Object result) {
             this.result = result;

modules/rank-eval/src/main/java/org/elasticsearch/index/rankeval/RankEvalResponse.java

@@ -30,11 +30,11 @@
 public class RankEvalResponse extends ActionResponse implements ToXContentObject {
 
     /** The overall evaluation result. */
-    private double metricScore;
+    private final double metricScore;
     /** details about individual ranking evaluation queries, keyed by their id */
-    private Map<String, EvalQueryQuality> details;
+    private final Map<String, EvalQueryQuality> details;
     /** exceptions for specific ranking evaluation queries, keyed by their id */
-    private Map<String, Exception> failures;
+    private final Map<String, Exception> failures;
 
     public RankEvalResponse(double metricScore, Map<String, EvalQueryQuality> partialResults, Map<String, Exception> failures) {
         this.metricScore = metricScore;

server/src/main/java/org/elasticsearch/action/admin/cluster/allocation/ClusterAllocationExplainResponse.java

@@ -22,7 +22,7 @@
  */
 public class ClusterAllocationExplainResponse extends ActionResponse implements ChunkedToXContentObject {
 
-    private ClusterAllocationExplanation cae;
+    private final ClusterAllocationExplanation cae;
 
     public ClusterAllocationExplainResponse(StreamInput in) throws IOException {
         super(in);

server/src/main/java/org/elasticsearch/action/admin/cluster/remote/RemoteInfoResponse.java

@@ -9,7 +9,6 @@
 package org.elasticsearch.action.admin.cluster.remote;
 
 import org.elasticsearch.action.ActionResponse;
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.transport.RemoteConnectionInfo;
 import org.elasticsearch.xcontent.ToXContentObject;
@@ -23,11 +22,6 @@ public final class RemoteInfoResponse extends ActionResponse implements ToXConte
 
     private final List<RemoteConnectionInfo> infos;
 
-    RemoteInfoResponse(StreamInput in) throws IOException {
-        super(in);
-        infos = in.readCollectionAsImmutableList(RemoteConnectionInfo::new);
-    }
-
     public RemoteInfoResponse(Collection<RemoteConnectionInfo> infos) {
         this.infos = List.copyOf(infos);
     }

server/src/main/java/org/elasticsearch/action/admin/cluster/state/ClusterStateResponse.java

@@ -23,9 +23,9 @@
  */
 public class ClusterStateResponse extends ActionResponse {
 
-    private ClusterName clusterName;
-    private ClusterState clusterState;
-    private boolean waitForTimedOut = false;
+    private final ClusterName clusterName;
+    private final ClusterState clusterState;
+    private final boolean waitForTimedOut;
 
     public ClusterStateResponse(StreamInput in) throws IOException {
         super(in);

server/src/main/java/org/elasticsearch/action/admin/cluster/storedscripts/GetStoredScriptResponse.java

@@ -26,8 +26,8 @@ public class GetStoredScriptResponse extends ActionResponse implements ToXConten
     public static final ParseField FOUND_PARSE_FIELD = new ParseField("found");
     public static final ParseField SCRIPT = new ParseField("script");
 
-    private String id;
-    private StoredScriptSource source;
+    private final String id;
+    private final StoredScriptSource source;
 
     public GetStoredScriptResponse(StreamInput in) throws IOException {
         super(in);

server/src/main/java/org/elasticsearch/action/get/MultiGetItemResponse.java

@@ -8,7 +8,6 @@
 
 package org.elasticsearch.action.get;
 
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.common.io.stream.Writeable;
 
@@ -27,16 +26,6 @@ public MultiGetItemResponse(GetResponse response, MultiGetResponse.Failure failu
         this.failure = failure;
     }
 
-    MultiGetItemResponse(StreamInput in) throws IOException {
-        if (in.readBoolean()) {
-            failure = new MultiGetResponse.Failure(in);
-            response = null;
-        } else {
-            response = new GetResponse(in);
-            failure = null;
-        }
-    }
-
     /**
      * The index name of the document.
      */

server/src/main/java/org/elasticsearch/action/get/MultiGetResponse.java

@@ -109,11 +109,6 @@ public MultiGetResponse(MultiGetItemResponse[] responses) {
         this.responses = responses;
     }
 
-    MultiGetResponse(StreamInput in) throws IOException {
-        super(in);
-        responses = in.readArray(MultiGetItemResponse::new, MultiGetItemResponse[]::new);
-    }
-
     public MultiGetItemResponse[] getResponses() {
         return this.responses;
     }

server/src/main/java/org/elasticsearch/action/ingest/SimulatePipelineResponse.java

@@ -20,9 +20,9 @@
 import java.util.List;
 
 public class SimulatePipelineResponse extends ActionResponse implements ToXContentObject {
-    private String pipelineId;
+    private final String pipelineId;
     private boolean verbose;
-    private List<SimulateDocumentResult> results;
+    private final List<SimulateDocumentResult> results;
 
     public SimulatePipelineResponse(StreamInput in) throws IOException {
         super(in);

server/src/main/java/org/elasticsearch/action/search/ClearScrollResponse.java

@@ -9,7 +9,6 @@
 package org.elasticsearch.action.search;
 
 import org.elasticsearch.action.ActionResponse;
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.rest.RestStatus;
 import org.elasticsearch.xcontent.ParseField;
@@ -34,12 +33,6 @@ public ClearScrollResponse(boolean succeeded, int numFreed) {
         this.numFreed = numFreed;
     }
 
-    public ClearScrollResponse(StreamInput in) throws IOException {
-        super(in);
-        succeeded = in.readBoolean();
-        numFreed = in.readVInt();
-    }
-
     /**
      * @return Whether the attempt to clear a scroll was successful.
      */

server/src/main/java/org/elasticsearch/action/search/ClosePointInTimeResponse.java

@@ -8,11 +8,8 @@
 
 package org.elasticsearch.action.search;
 
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.rest.RestStatus;
 
-import java.io.IOException;
-
 import static org.elasticsearch.rest.RestStatus.NOT_FOUND;
 import static org.elasticsearch.rest.RestStatus.OK;
 
@@ -21,10 +18,6 @@ public ClosePointInTimeResponse(boolean succeeded, int numFreed) {
         super(succeeded, numFreed);
     }
 
-    public ClosePointInTimeResponse(StreamInput in) throws IOException {
-        super(in);
-    }
-
     @Override
     public RestStatus status() {
         if (isSucceeded() || getNumFreed() > 0) {

server/src/main/java/org/elasticsearch/action/search/OpenPointInTimeResponse.java

@@ -9,7 +9,6 @@
 package org.elasticsearch.action.search;
 
 import org.elasticsearch.action.ActionResponse;
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.xcontent.ToXContentObject;
 import org.elasticsearch.xcontent.XContentBuilder;
@@ -24,11 +23,6 @@ public OpenPointInTimeResponse(String pointInTimeId) {
         this.pointInTimeId = Objects.requireNonNull(pointInTimeId, "Point in time parameter must be not null");
     }
 
-    public OpenPointInTimeResponse(StreamInput in) throws IOException {
-        super(in);
-        pointInTimeId = in.readString();
-    }
-
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         out.writeString(pointInTimeId);

server/src/main/java/org/elasticsearch/action/support/replication/TransportReplicationAction.java

@@ -1183,8 +1183,8 @@ public PendingReplicationActions getPendingReplicationActions() {
     }
 
     public static class ReplicaResponse extends ActionResponse implements ReplicationOperation.ReplicaResponse {
-        private long localCheckpoint;
-        private long globalCheckpoint;
+        private final long localCheckpoint;
+        private final long globalCheckpoint;
 
         ReplicaResponse(StreamInput in) throws IOException {
             super(in);

server/src/main/java/org/elasticsearch/action/support/tasks/BaseTasksResponse.java

@@ -35,8 +35,8 @@ public class BaseTasksResponse extends ActionResponse {
     public static final String TASK_FAILURES = "task_failures";
     public static final String NODE_FAILURES = "node_failures";
 
-    private List<TaskOperationFailure> taskFailures;
-    private List<ElasticsearchException> nodeFailures;
+    private final List<TaskOperationFailure> taskFailures;
+    private final List<ElasticsearchException> nodeFailures;
 
     public BaseTasksResponse(List<TaskOperationFailure> taskFailures, List<? extends ElasticsearchException> nodeFailures) {
         this.taskFailures = taskFailures == null ? Collections.emptyList() : List.copyOf(taskFailures);

server/src/main/java/org/elasticsearch/action/termvectors/MultiTermVectorsResponse.java

@@ -91,11 +91,6 @@ public MultiTermVectorsResponse(MultiTermVectorsItemResponse[] responses) {
         this.responses = responses;
     }
 
-    public MultiTermVectorsResponse(StreamInput in) throws IOException {
-        super(in);
-        responses = in.readArray(MultiTermVectorsItemResponse::new, MultiTermVectorsItemResponse[]::new);
-    }
-
     public MultiTermVectorsItemResponse[] getResponses() {
         return this.responses;
     }

server/src/main/java/org/elasticsearch/index/reindex/BulkByScrollResponse.java

@@ -30,10 +30,10 @@
  * Response used for actions that index many documents using a scroll request.
  */
 public class BulkByScrollResponse extends ActionResponse implements ToXContentFragment {
-    private TimeValue took;
-    private BulkByScrollTask.Status status;
-    private List<Failure> bulkFailures;
-    private List<ScrollableHitSource.SearchFailure> searchFailures;
+    private final TimeValue took;
+    private final BulkByScrollTask.Status status;
+    private final List<Failure> bulkFailures;
+    private final List<ScrollableHitSource.SearchFailure> searchFailures;
     private boolean timedOut;
 
     static final String TOOK_FIELD = "took";

server/src/main/java/org/elasticsearch/persistent/PersistentTaskResponse.java

@@ -19,7 +19,7 @@
  * Response upon a successful start or an persistent task
  */
 public class PersistentTaskResponse extends ActionResponse {
-    private PersistentTask<?> task;
+    private final PersistentTask<?> task;
 
     public PersistentTaskResponse(StreamInput in) throws IOException {
         super(in);

x-pack/plugin/core/src/main/java/org/elasticsearch/license/GetBasicStatusResponse.java

@@ -17,7 +17,7 @@
 
 public class GetBasicStatusResponse extends ActionResponse implements ToXContentObject {
 
-    private boolean eligibleToStartBasic;
+    private final boolean eligibleToStartBasic;
 
     GetBasicStatusResponse(StreamInput in) throws IOException {
         super(in);

x-pack/plugin/core/src/main/java/org/elasticsearch/license/GetTrialStatusResponse.java

@@ -17,7 +17,7 @@
 
 public class GetTrialStatusResponse extends ActionResponse implements ToXContentObject {
 
-    private boolean eligibleToStartTrial;
+    private final boolean eligibleToStartTrial;
 
     GetTrialStatusResponse(StreamInput in) throws IOException {
         super(in);

x-pack/plugin/core/src/main/java/org/elasticsearch/license/PostStartTrialResponse.java

@@ -48,9 +48,9 @@ RestStatus getRestStatus() {
 
     }
 
-    private Status status;
-    private Map<String, String[]> acknowledgeMessages;
-    private String acknowledgeMessage;
+    private final Status status;
+    private final Map<String, String[]> acknowledgeMessages;
+    private final String acknowledgeMessage;
 
     PostStartTrialResponse(StreamInput in) throws IOException {
         super(in);

x-pack/plugin/core/src/main/java/org/elasticsearch/protocol/xpack/XPackInfoResponse.java

@@ -38,11 +38,11 @@ public class XPackInfoResponse extends ActionResponse implements ToXContentObjec
     // TODO move this constant to License.java once we move License.java to the protocol jar
 
     @Nullable
-    private BuildInfo buildInfo;
+    private final BuildInfo buildInfo;
     @Nullable
-    private LicenseInfo licenseInfo;
+    private final LicenseInfo licenseInfo;
     @Nullable
-    private FeatureSetsInfo featureSetsInfo;
+    private final FeatureSetsInfo featureSetsInfo;
 
     public XPackInfoResponse(StreamInput in) throws IOException {
         super(in);