Skip to content

Commit 1f69c72

Browse files
cb is back
1 parent 196bc9d commit 1f69c72

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

server/src/main/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncAction.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
import org.elasticsearch.action.support.IndicesOptions;
2424
import org.elasticsearch.client.internal.Client;
2525
import org.elasticsearch.cluster.ClusterState;
26-
import org.elasticsearch.common.breaker.CircuitBreaker;
27-
import org.elasticsearch.common.breaker.NoopCircuitBreaker;
2826
import org.elasticsearch.common.io.stream.NamedWriteableRegistry;
2927
import org.elasticsearch.common.io.stream.StreamInput;
3028
import org.elasticsearch.common.io.stream.StreamOutput;
@@ -548,8 +546,6 @@ private void onNodeQueryFailure(Exception e, NodeQueryRequest request, CanMatchP
548546

549547
private static final String NODE_SEARCH_ACTION_NAME = "indices:data/read/search[query][n]";
550548

551-
private static final CircuitBreaker NOOP_CIRCUIT_BREAKER = new NoopCircuitBreaker("request");
552-
553549
static void registerNodeSearchAction(
554550
SearchTransportService searchTransportService,
555551
SearchService searchService,
@@ -573,7 +569,7 @@ static void registerNodeSearchAction(
573569
new QueryPhaseResultConsumer(
574570
request.searchRequest,
575571
dependencies.executor,
576-
NOOP_CIRCUIT_BREAKER, // noop cb for now since we do not have a breaker in this situation in un-batched execution
572+
searchService.getCircuitBreaker(),
577573
searchPhaseController,
578574
cancellableTask::isCancelled,
579575
SearchProgressListener.NOOP,

server/src/main/java/org/elasticsearch/search/SearchService.java

+4
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,10 @@ public SearchService(
421421
.addSettingsUpdateConsumer(MEMORY_ACCOUNTING_BUFFER_SIZE, newValue -> this.memoryAccountingBufferSize = newValue.getBytes());
422422
}
423423

424+
public CircuitBreaker getCircuitBreaker() {
425+
return circuitBreaker;
426+
}
427+
424428
private void setEnableSearchWorkerThreads(boolean enableSearchWorkerThreads) {
425429
if (enableSearchWorkerThreads) {
426430
searchExecutor = threadPool.executor(Names.SEARCH);

0 commit comments

Comments
 (0)