Skip to content

Commit ec619f2

Browse files
committed
Updating syntax and dependencies to match Atlas Workers Ruby version
While I was testing this locally, I noticed that there was still Ruby 2.x era syntax in the scripts and spec files. I went ahead and updated those and also set the Ruby version in the Gemfile to match what's on the Workers. EDIT: Updating Ruby version in GitHub CI
1 parent a0c8279 commit ec619f2

File tree

5 files changed

+420
-416
lines changed

5 files changed

+420
-416
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Set up Ruby
2020
uses: ruby/setup-ruby@v1
2121
with:
22-
ruby-version: 3.1
22+
ruby-version: 3.3.6
2323
bundler-cache: true
2424
- name: Run tests
2525
run: bundle exec rspec spec/htmlbook_spec.rb

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
source 'https://rubygems.org'
2+
ruby "3.3.6"
23

34
group :test do
45
gem "asciidoctor"

Gemfile.lock

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
GEM
22
remote: https://rubygems.org/
33
specs:
4-
asciidoctor (2.0.17)
5-
concurrent-ruby (1.1.10)
6-
diff-lcs (1.6.0)
4+
asciidoctor (2.0.23)
5+
concurrent-ruby (1.3.5)
6+
diff-lcs (1.6.1)
77
mini_portile2 (2.8.8)
8-
nokogiri (1.18.4)
8+
nokogiri (1.18.7)
99
mini_portile2 (~> 2.8.2)
1010
racc (~> 1.4)
1111
racc (1.8.1)
@@ -22,7 +22,7 @@ GEM
2222
diff-lcs (>= 1.2.0, < 2.0)
2323
rspec-support (~> 3.13.0)
2424
rspec-support (3.13.2)
25-
tilt (1.4.1)
25+
tilt (2.6.0)
2626

2727
PLATFORMS
2828
ruby
@@ -34,5 +34,8 @@ DEPENDENCIES
3434
rspec
3535
tilt
3636

37+
RUBY VERSION
38+
ruby 3.3.6p108
39+
3740
BUNDLED WITH
3841
2.4.19

scripts/convert_book.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
require 'fileutils'
55

66
book_folder = ARGV[0]
7-
raise "Book Folder does not exist: #{book_folder}" unless File.exists?(book_folder)
7+
raise "Book Folder does not exist: #{book_folder}" unless File.exist?(book_folder)
88

99
Dir.glob("#{book_folder}**/*.{asciidoc,adoc,asc}") do |file|
1010
puts "Converting #{File.basename(file)}"

0 commit comments

Comments
 (0)