Skip to content

cert_bundle Not Used in refresh Subcommand for Session #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
raghav1674 opened this issue Aug 7, 2024 · 1 comment · May be fixed by #836
Open

cert_bundle Not Used in refresh Subcommand for Session #835

raghav1674 opened this issue Aug 7, 2024 · 1 comment · May be fixed by #836

Comments

@raghav1674
Copy link

Description:

The cert_bundle option is a valid configuration for the session subcommand. However, the refresh subcommand within session does not utilize the cert_bundle option when making the request to refresh the token. This can cause issues in environments where a custom certificate bundle is required for HTTPS requests.

Steps to Reproduce:

  1. Run the oci session refresh with --cert-bundle subcommand.
  2. Observe that the cert_bundle is not passed to the requests.post call.

Expected Behavior:

The refresh subcommand should include the cert_bundle in the request parameters if it is set.
raghav1674 added a commit to raghav1674/oci-cli that referenced this issue Aug 7, 2024
@raghav1674
include cert_bundle in session refresh requests
d977ce4 
fixes oracle#835

Signed-off-by: raghav1674 <[email protected]>
@raghav1674 raghav1674 linked a pull request Aug 7, 2024 that will close this issue
Open
@karthik-k-kamath
Copy link
Member

Thanks @raghav1674 , we already have this fix in progress and plan to release it in Sept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include cert_bundle in session refresh requests raghav1674/oci-cli
2 participants
@raghav1674 @karthik-k-kamath