Skip to content

Commit e5580c6

Browse files
committed
remove engine api validate for optimism
1 parent fadb0d5 commit e5580c6

File tree

6 files changed

+16
-18
lines changed

6 files changed

+16
-18
lines changed

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineGetPayloadV2.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ protected JsonRpcResponse createResponse(
6868

6969
@Override
7070
protected ValidationResult<RpcErrorType> validateForkSupported(final long blockTimestamp) {
71+
if (this.mergeContext.get().isOptimism()) {
72+
return ValidationResult.valid();
73+
}
7174
if (cancunMilestone.isPresent() && blockTimestamp >= cancunMilestone.get()) {
7275
return ValidationResult.invalid(RpcErrorType.UNSUPPORTED_FORK);
7376
}

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineGetPayloadV3.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ protected JsonRpcResponse createResponse(
6868

6969
@Override
7070
protected ValidationResult<RpcErrorType> validateForkSupported(final long blockTimestamp) {
71+
if (this.mergeContext.get().isOptimism()) {
72+
return ValidationResult.valid();
73+
}
7174
return ForkSupportHelper.validateForkSupported(CANCUN, cancunMilestone, blockTimestamp);
7275
}
7376
}

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineNewPayloadV2.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import io.vertx.core.Vertx;
3636

3737
public class EngineNewPayloadV2 extends AbstractEngineNewPayload {
38-
private final Optional<Long> cancunMilestone;
3938

4039
public EngineNewPayloadV2(
4140
final Vertx vertx,
@@ -45,7 +44,6 @@ public EngineNewPayloadV2(
4544
final EthPeers ethPeers,
4645
final EngineCallListener engineCallListener) {
4746
super(vertx, protocolSchedule, protocolContext, mergeCoordinator, ethPeers, engineCallListener);
48-
cancunMilestone = protocolSchedule.milestoneFor(CANCUN);
4947
}
5048

5149
@Override
@@ -81,10 +79,6 @@ protected ValidationResult<RpcErrorType> validateBlobs(
8179

8280
@Override
8381
protected ValidationResult<RpcErrorType> validateForkSupported(final long blockTimestamp) {
84-
if (cancunMilestone.isPresent() && blockTimestamp >= cancunMilestone.get()) {
85-
return ValidationResult.invalid(RpcErrorType.UNSUPPORTED_FORK);
86-
}
87-
8882
return ValidationResult.valid();
8983
}
9084
}

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineNewPayloadV3.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,9 @@ protected ValidationResult<RpcErrorType> validateParameters(
7676

7777
@Override
7878
protected ValidationResult<RpcErrorType> validateForkSupported(final long blockTimestamp) {
79+
if (this.mergeContext.get().isOptimism()) {
80+
return ValidationResult.valid();
81+
}
7982
return ForkSupportHelper.validateForkSupported(CANCUN, cancunMilestone, blockTimestamp);
8083
}
8184
}

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/methods/ExecutionEngineJsonRpcMethods.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -147,18 +147,10 @@ protected Map<String, JsonRpcMethod> create() {
147147
new EngineExchangeCapabilities(
148148
consensusEngineServer, protocolContext, engineQosTimer),
149149
new EnginePreparePayloadDebug(
150-
consensusEngineServer, protocolContext, engineQosTimer, mergeCoordinator.get())));
151-
152-
if (protocolSchedule.anyMatch(p -> p.spec().getName().equalsIgnoreCase("cancun"))) {
153-
executionEngineApisSupported.add(
154-
new EngineGetPayloadV3(
155-
consensusEngineServer,
156-
protocolContext,
157-
mergeCoordinator.get(),
158-
blockResultFactory,
159-
engineQosTimer,
160-
protocolSchedule));
161-
}
150+
consensusEngineServer, protocolContext, engineQosTimer, mergeCoordinator.get()),
151+
new EngineGetPayloadV3(
152+
consensusEngineServer, protocolContext, mergeCoordinator.get(), blockResultFactory, engineQosTimer,
153+
protocolSchedule)));
162154

163155
if (protocolSchedule.anyMatch(p -> p.spec().getName().equalsIgnoreCase("prague"))) {
164156
executionEngineApisSupported.add(

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1102,6 +1102,7 @@ static ProtocolSpecBuilder canyonDefinition(
11021102
.precompileContractRegistryBuilder(MainnetPrecompiledContractRegistries::cancun)
11031103
.blockHeaderValidatorBuilder(MainnetBlockHeaderValidator::cancunBlockHeaderValidator)
11041104
.blockHashProcessor(new CancunBlockHashProcessor())
1105+
.genesisConfigOptions(Optional.of(genesisConfigOptions))
11051106
.name("Canyon");
11061107
}
11071108

@@ -1179,6 +1180,7 @@ static ProtocolSpecBuilder fjordDefinition(
11791180
.precompileContractRegistryBuilder(MainnetPrecompiledContractRegistries::fjord)
11801181
.blockHeaderValidatorBuilder(MainnetBlockHeaderValidator::cancunBlockHeaderValidator)
11811182
.blockHashProcessor(new CancunBlockHashProcessor())
1183+
.genesisConfigOptions(Optional.of(genesisConfigOptions))
11821184
.name("Fjord");
11831185
}
11841186

@@ -1256,6 +1258,7 @@ static ProtocolSpecBuilder graniteDefinition(
12561258
.precompileContractRegistryBuilder(MainnetPrecompiledContractRegistries::granite)
12571259
.blockHeaderValidatorBuilder(MainnetBlockHeaderValidator::cancunBlockHeaderValidator)
12581260
.blockHashProcessor(new CancunBlockHashProcessor())
1261+
.genesisConfigOptions(Optional.of(genesisConfigOptions))
12591262
.name("Granite");
12601263
}
12611264

0 commit comments

Comments
 (0)