Skip to content

Commit a3eccaf

Browse files
artek-koltunglimchb
authored andcommitted
feat(storage): required changes after annotations
Signed-off-by: Artsiom Koltun <[email protected]>
1 parent 33688b8 commit a3eccaf

File tree

1 file changed

+53
-11
lines changed

1 file changed

+53
-11
lines changed

storage/frontend.go

+53-11
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@ import (
1414
"github.com/google/uuid"
1515
pbc "github.com/opiproject/opi-api/common/v1/gen/go"
1616
pb "github.com/opiproject/opi-api/storage/v1alpha1/gen/go"
17+
"google.golang.org/protobuf/proto"
1718

1819
"google.golang.org/grpc"
1920
"google.golang.org/protobuf/types/known/fieldmaskpb"
21+
"google.golang.org/protobuf/types/known/wrapperspb"
2022
)
2123

2224
// DoFrontend executes the front end code
@@ -58,7 +60,15 @@ func executeVirtioScsiLun(ctx context.Context, c6 pb.FrontendVirtioScsiServiceCl
5860
log.Printf("=======================================")
5961
const resourceID = "opi-virtio-scsi8"
6062
// pre create: controller
61-
rss1, err := c6.CreateVirtioScsiController(ctx, &pb.CreateVirtioScsiControllerRequest{VirtioScsiControllerId: resourceID, VirtioScsiController: &pb.VirtioScsiController{Name: ""}})
63+
rss1, err := c6.CreateVirtioScsiController(ctx, &pb.CreateVirtioScsiControllerRequest{
64+
VirtioScsiControllerId: resourceID,
65+
VirtioScsiController: &pb.VirtioScsiController{
66+
Name: "",
67+
PcieId: &pb.PciEndpoint{
68+
PhysicalFunction: wrapperspb.Int32(1),
69+
VirtualFunction: wrapperspb.Int32(2),
70+
PortId: wrapperspb.Int32(3)},
71+
}})
6272
if err != nil {
6373
return err
6474
}
@@ -117,7 +127,15 @@ func executeVirtioScsiController(ctx context.Context, c5 pb.FrontendVirtioScsiSe
117127

118128
// testing with and without {resource}_id field
119129
for _, resourceID := range []string{"opi-virtio-scsi8", ""} {
120-
rss1, err := c5.CreateVirtioScsiController(ctx, &pb.CreateVirtioScsiControllerRequest{VirtioScsiControllerId: resourceID, VirtioScsiController: &pb.VirtioScsiController{Name: ""}})
130+
rss1, err := c5.CreateVirtioScsiController(ctx, &pb.CreateVirtioScsiControllerRequest{
131+
VirtioScsiControllerId: resourceID,
132+
VirtioScsiController: &pb.VirtioScsiController{
133+
Name: "",
134+
PcieId: &pb.PciEndpoint{
135+
PhysicalFunction: wrapperspb.Int32(1),
136+
VirtualFunction: wrapperspb.Int32(2),
137+
PortId: wrapperspb.Int32(3)},
138+
}})
121139
if err != nil {
122140
return err
123141
}
@@ -136,8 +154,14 @@ func executeVirtioScsiController(ctx context.Context, c5 pb.FrontendVirtioScsiSe
136154
}
137155
log.Printf("Added VirtioScsiController: %v", rss1)
138156
rss3, err := c5.UpdateVirtioScsiController(ctx, &pb.UpdateVirtioScsiControllerRequest{
139-
UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"*"}},
140-
VirtioScsiController: &pb.VirtioScsiController{Name: rss1.Name}})
157+
UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"*"}},
158+
VirtioScsiController: &pb.VirtioScsiController{
159+
Name: rss1.Name,
160+
PcieId: &pb.PciEndpoint{
161+
PhysicalFunction: wrapperspb.Int32(1),
162+
VirtualFunction: wrapperspb.Int32(2),
163+
PortId: wrapperspb.Int32(3)},
164+
}})
141165
if err != nil {
142166
return err
143167
}
@@ -173,7 +197,16 @@ func executeVirtioBlk(ctx context.Context, c4 pb.FrontendVirtioBlkServiceClient)
173197

174198
// testing with and without {resource}_id field
175199
for _, resourceID := range []string{"opi-virtio-blk8", ""} {
176-
rv1, err := c4.CreateVirtioBlk(ctx, &pb.CreateVirtioBlkRequest{VirtioBlkId: resourceID, VirtioBlk: &pb.VirtioBlk{Name: "", VolumeNameRef: "Malloc1"}})
200+
rv1, err := c4.CreateVirtioBlk(ctx, &pb.CreateVirtioBlkRequest{
201+
VirtioBlkId: resourceID,
202+
VirtioBlk: &pb.VirtioBlk{
203+
Name: "",
204+
VolumeNameRef: "Malloc1",
205+
PcieId: &pb.PciEndpoint{
206+
PhysicalFunction: wrapperspb.Int32(1),
207+
VirtualFunction: wrapperspb.Int32(2),
208+
PortId: wrapperspb.Int32(3)},
209+
}})
177210
if err != nil {
178211
return err
179212
}
@@ -253,12 +286,15 @@ func executeNvmeNamespace(ctx context.Context, c2 pb.FrontendNvmeServiceClient)
253286
NvmeController: &pb.NvmeController{
254287
Spec: &pb.NvmeControllerSpec{
255288
SubsystemNameRef: rs1.Name,
256-
PcieId: &pb.PciEndpoint{PhysicalFunction: 1, VirtualFunction: 2, PortId: 3},
289+
PcieId: &pb.PciEndpoint{
290+
PhysicalFunction: wrapperspb.Int32(1),
291+
VirtualFunction: wrapperspb.Int32(2),
292+
PortId: wrapperspb.Int32(3)},
257293
MaxNsq: 5,
258294
MaxNcq: 6,
259295
Sqes: 7,
260296
Cqes: 8,
261-
NvmeControllerId: 1}}})
297+
NvmeControllerId: proto.Int32(1)}}})
262298
if err != nil {
263299
return err
264300
}
@@ -386,12 +422,15 @@ func executeNvmeController(ctx context.Context, c2 pb.FrontendNvmeServiceClient)
386422
NvmeController: &pb.NvmeController{
387423
Spec: &pb.NvmeControllerSpec{
388424
SubsystemNameRef: rs1.Name,
389-
PcieId: &pb.PciEndpoint{PhysicalFunction: 1, VirtualFunction: 2, PortId: 3},
425+
PcieId: &pb.PciEndpoint{
426+
PhysicalFunction: wrapperspb.Int32(1),
427+
VirtualFunction: wrapperspb.Int32(2),
428+
PortId: wrapperspb.Int32(3)},
390429
MaxNsq: 5,
391430
MaxNcq: 6,
392431
Sqes: 7,
393432
Cqes: 8,
394-
NvmeControllerId: 1}}})
433+
NvmeControllerId: proto.Int32(1)}}})
395434
if err != nil {
396435
return err
397436
}
@@ -415,12 +454,15 @@ func executeNvmeController(ctx context.Context, c2 pb.FrontendNvmeServiceClient)
415454
Name: rc1.Name,
416455
Spec: &pb.NvmeControllerSpec{
417456
SubsystemNameRef: rs1.Name,
418-
PcieId: &pb.PciEndpoint{PhysicalFunction: 3, VirtualFunction: 2, PortId: 1},
457+
PcieId: &pb.PciEndpoint{
458+
PhysicalFunction: wrapperspb.Int32(3),
459+
VirtualFunction: wrapperspb.Int32(2),
460+
PortId: wrapperspb.Int32(1)},
419461
MaxNsq: 8,
420462
MaxNcq: 7,
421463
Sqes: 6,
422464
Cqes: 5,
423-
NvmeControllerId: 1}}})
465+
NvmeControllerId: proto.Int32(1)}}})
424466
if err != nil {
425467
return err
426468
}

0 commit comments

Comments
 (0)