-
Notifications
You must be signed in to change notification settings - Fork 317
Firefox installation fails for older versions #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, thanks for reporting this issue. I think, we'd still need to manually copy the tars over to that repo, so the comment would remain relevant. Iirc other people keep the OpenWPM code and their code separated by using a git submodule. Tbh I always assumed that people would just check out one version and build on top of it (as you apparently have done) and never upgrade. Thank you for your appreciation! |
I was thinking exactly that, it would help keeping research reproducible! And you are right that the comment in
Given how much changed since v0.12.0, I will just get an old Firefox release from backups to do the changes that I needed before Christmas. But when I find more spare time, I will update our whole crawler to the newest OpenWPM release included as a submodule. So I can tell after New Year if I run into some problems. |
Uh oh!
There was an error while loading. Please reload this page.
Hi,
The script
./scripts/install-firefox.sh
for OpenWPM v0.12.0 tries to download Firefox from this link: https://firefox-ci-tc.services.mozilla.com/api/index/v1/task/gecko.v2.mozilla-release.revision.bd5d1f49975deb730064a16b3079edb53c4a5f84.firefox.linux64-add-on-devel/artifacts/public/build/target.tar.bz2. The problem with this link is that Firefox seems to remove old tags from https://firefox-ci-tc.services.mozilla.com/tasks/index/gecko.v2.mozilla-release.revision. I checked older tags and they are also unavailable, newer tags from v0.14.0 (FIREFOX_86_0_1_RELEASE) are available.I did not manage to find any alternative repository with these FF builds. I understand that the issue is not on your side, but with the versioning it seems that you want to keep research with older versions reproducible. What about mirroring builds of the few fixed releases that made it into a stable OpenWPM version? It might resolve the comment in the beginning of
./scripts/install-firefox.sh
.Additional question regarding versioning. Do you suggest to clone the newest version of OpenWPM (git submodule or by some script that downloads OpenWPM) to projects that build upon it? At the moment, we were including the specific version and edited it, which caused this issue. Long term maintainable solution is I guess not touching included OpenWPM code and extending/monkey patching it within our files.
Thanks! I appreciate your work on this project, maintaining a research tool is a tough task.
The text was updated successfully, but these errors were encountered: