[fix] Added config settings permissions to default groups #664

Fixes #664

Author: codesankalp

openwisp_controller/config/migrations/0041_default_groups_organizationconfigsettings_permission.py

@@ -0,0 +1,19 @@
+# Generated by Django 4.0.5 on 2022-06-21 17:49
+
+from django.db import migrations
+
+from . import assign_organization_config_settings_permissions_to_groups
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('config', '0040_vpnclient_ip_setnull'),
+    ]
+
+    operations = [
+        migrations.RunPython(
+            code=assign_organization_config_settings_permissions_to_groups,
+            reverse_code=migrations.operations.special.RunPython.noop,
+        )
+    ]

openwisp_controller/config/migrations/__init__.py

@@ -78,3 +78,24 @@ def assign_devicegroup_permissions_to_groups(apps, schema_editor):
         )
         admin.permissions.add(permission.pk)
         operator.permissions.add(permission.pk)
+
+
+def assign_organization_config_settings_permissions_to_groups(apps, schema_editor):
+    create_default_permissions(apps, schema_editor)
+    operator_operations = ['view']
+    admin_operations = operator_operations + ['change']
+    Group = get_swapped_model(apps, 'openwisp_users', 'Group')
+    try:
+        admin = Group.objects.get(name='Administrator')
+        operator = Group.objects.get(name='Operator')
+    # consider failures custom cases
+    # that do not have to be dealt with
+    except Group.DoesNotExist:
+        return
+    for operation in admin_operations:
+        permission = Permission.objects.get(
+            codename='{}_{}'.format(operation, 'organizationconfigsettings')
+        )
+        if operation in operator_operations:
+            operator.permissions.add(permission.pk)
+        admin.permissions.add(permission.pk)

tests/openwisp2/sample_config/migrations/0002_default_groups_permissions.py

@@ -2,6 +2,7 @@
 
 from openwisp_controller.config.migrations import (
     assign_devicegroup_permissions_to_groups,
+    assign_organization_config_settings_permissions_to_groups,
     assign_permissions_to_groups,
 )
 
@@ -17,4 +18,8 @@ class Migration(migrations.Migration):
             assign_devicegroup_permissions_to_groups,
             reverse_code=migrations.RunPython.noop,
         ),
+        migrations.RunPython(
+            code=assign_organization_config_settings_permissions_to_groups,
+            reverse_code=migrations.operations.special.RunPython.noop,
+        ),
     ]