[change] Fixed the URL structure for downloading CA's CRL

Signed-off-by: Gagan Deep <[email protected]>
Co-authored-by: Federico Capoano <[email protected]>

Author: pandafy

django_x509/base/admin.py

@@ -136,7 +136,9 @@ class Media:
 
     def get_urls(self):
         return [
-            path('x509/ca/<int:pk>.crl', self.crl_view, name='crl')
+            path('<int:pk>.crl', self.crl_view, name='crl'),
+            # old URL path, deprecated, will be removed in future versions
+            path('x509/ca/<int:pk>.crl', self.crl_view, name='deprecated_crl'),
         ] + super().get_urls()
 
     def crl_view(self, request, pk):

django_x509/tests/test_ca.py

@@ -20,6 +20,8 @@ class TestCa(TestX509Mixin, TestCase):
     tests for Ca model
     """
 
+    app_label = Ca._meta.app_label
+
     def _prepare_revoked(self):
         ca = self._create_ca()
         crl = crypto.load_crl(crypto.FILETYPE_PEM, ca.crl)
@@ -313,7 +315,13 @@ def test_crl(self):
 
     def test_crl_view(self):
         ca, cert = self._prepare_revoked()
-        response = self.client.get(reverse('admin:crl', args=[ca.pk]))
+        path = reverse('admin:crl', args=[ca.pk])
+        self.assertEqual(path, f'/admin/{self.app_label}/ca/{ca.pk}.crl')
+        deprecated_path = reverse('admin:deprecated_crl', args=[ca.pk])
+        self.assertEqual(
+            deprecated_path, f'/admin/{self.app_label}/ca/x509/ca/{ca.pk}.crl'
+        )
+        response = self.client.get(path)
         self.assertEqual(response.status_code, 200)
         crl = crypto.load_crl(crypto.FILETYPE_PEM, response.content)
         revoked_list = crl.get_revoked()