Refactor service_types()

Patrik-Stas · Patrik-Stas · commit 1550c5e52920 · 2024-01-15T11:00:49.000+01:00
Signed-off-by: Patrik Stas &lt;patrik.stas@absa.africa&gt;
diff --git a/did_core/did_doc/src/schema/service/mod.rs b/did_core/did_doc/src/schema/service/mod.rs
@@ -51,10 +51,10 @@ impl Service {
         &self.service_type
     }
 
-    pub fn service_types(&self) -> Vec<ServiceType> {
+    pub fn service_types(&self) -> &[ServiceType] {
         match &self.service_type {
-            OneOrList::One(service_type) => vec![service_type.clone()],
-            OneOrList::List(service_types) => service_types.clone(),
+            OneOrList::One(service_type) => std::slice::from_ref(service_type),
+            OneOrList::List(service_types) => service_types.as_slice()
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,10 @@ impl Service {`
`51`	`51`	`&self.service_type`
`52`	`52`	`}`
`53`	`53`
`54`		`- pub fn service_types(&self) -> Vec<ServiceType> {`
	`54`	`+ pub fn service_types(&self) -> &[ServiceType] {`
`55`	`55`	`match &self.service_type {`
`56`		`- OneOrList::One(service_type) => vec![service_type.clone()],`
`57`		`- OneOrList::List(service_types) => service_types.clone(),`
	`56`	`+ OneOrList::One(service_type) => std::slice::from_ref(service_type),`
	`57`	`+ OneOrList::List(service_types) => service_types.as_slice()`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`