Skip to content

Commit b60f20f

Browse files
committed
Update unit tests
Signed-off-by: jamshale <[email protected]>
1 parent aed9986 commit b60f20f

File tree

2 files changed

+5
-37
lines changed

2 files changed

+5
-37
lines changed

acapy_agent/anoncreds/tests/test_holder.py

+4-36
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,6 @@ def __init__(self, bad_schema=False, bad_cred_def=False):
5555
self.schema_id = "Sc886XPwD1gDcHwmmLDeR2:2:degree schema:45.101.94"
5656
self.cred_def_id = "Sc886XPwD1gDcHwmmLDeR2:3:CL:229975:faber.agent.degree_schema"
5757

58-
if bad_schema:
59-
self.schema_id = "bad-schema-id"
60-
if bad_cred_def:
61-
self.cred_def_id = "bad-cred-def-id"
62-
6358
schema_id = "Sc886XPwD1gDcHwmmLDeR2:2:degree schema:45.101.94"
6459
cred_def_id = "Sc886XPwD1gDcHwmmLDeR2:3:CL:229975:faber.agent.degree_schema"
6560
rev_reg_id = None
@@ -72,15 +67,10 @@ def to_dict(self):
7267

7368

7469
class MockCredReceivedW3C:
75-
def __init__(self, bad_schema=False, bad_cred_def=False):
70+
def __init__(self):
7671
self.schema_id = "Sc886XPwD1gDcHwmmLDeR2:2:degree schema:45.101.94"
7772
self.cred_def_id = "Sc886XPwD1gDcHwmmLDeR2:3:CL:229975:faber.agent.degree_schema"
7873

79-
if bad_schema:
80-
self.schema_id = "bad-schema-id"
81-
if bad_cred_def:
82-
self.cred_def_id = "bad-cred-def-id"
83-
8474
def to_json_buffer(self):
8575
return b"credential"
8676

@@ -89,9 +79,7 @@ def to_dict(self):
8979

9080

9181
class MockCredential:
92-
def __init__(self, bad_schema=False, bad_cred_def=False):
93-
self.bad_schema = bad_schema
94-
self.bad_cred_def = bad_cred_def
82+
def __init__(self):
9583
self.rev_reg_id = "rev-reg-id"
9684
self.rev_reg_index = 0
9785

@@ -101,21 +89,17 @@ def to_dict(self):
10189
return MOCK_CRED
10290

10391
def process(self, *args, **kwargs):
104-
return MockCredReceived(self.bad_schema, self.bad_cred_def)
92+
return MockCredReceived()
10593

10694

10795
class MockW3Credential:
108-
def __init__(self, bad_schema=False, bad_cred_def=False):
109-
self.bad_schema = bad_schema
110-
self.bad_cred_def = bad_cred_def
111-
11296
cred = mock.AsyncMock(auto_spec=W3cCredential)
11397

11498
def to_dict(self):
11599
return MOCK_W3C_CRED
116100

117101
def process(self, *args, **kwargs):
118-
return MockCredReceivedW3C(self.bad_schema, self.bad_cred_def)
102+
return MockCredReceivedW3C()
119103

120104

121105
class MockMasterSecret:
@@ -285,8 +269,6 @@ async def test_store_credential_fails_to_load_raises_x(self, mock_master_secret)
285269
side_effect=[
286270
MockCredential(),
287271
MockCredential(),
288-
MockCredential(bad_schema=True),
289-
MockCredential(bad_cred_def=True),
290272
],
291273
)
292274
async def test_store_credential(self, mock_load, mock_master_secret):
@@ -321,20 +303,6 @@ async def test_store_credential(self, mock_load, mock_master_secret):
321303
{"cred-req-meta": "cred-req-meta"},
322304
)
323305

324-
# Test bad id's
325-
with self.assertRaises(AnonCredsHolderError):
326-
await self.holder.store_credential(
327-
MOCK_CRED_DEF,
328-
MOCK_PRES,
329-
{"cred-req-meta": "cred-req-meta"},
330-
)
331-
with self.assertRaises(AnonCredsHolderError):
332-
await self.holder.store_credential(
333-
MOCK_CRED_DEF,
334-
MOCK_CRED,
335-
{"cred-req-meta": "cred-req-meta"},
336-
)
337-
338306
@mock.patch.object(AnonCredsHolder, "get_master_secret", return_value="master-secret")
339307
@mock.patch.object(
340308
W3cCredential,

acapy_agent/protocols/issue_credential/v2_0/formats/anoncreds/tests/test_handler.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
"nonce": "1234567890",
133133
}
134134
ANONCREDS_CRED_REQ = {
135-
"prover_did": TEST_DID,
135+
"entropy": TEST_DID,
136136
"cred_def_id": CRED_DEF_ID,
137137
"blinded_ms": {
138138
"u": "12345",

0 commit comments

Comments
 (0)