Fix proto 1.1.0 trace flags (#1216)

Nevay · web-flow · commit db7b96bd0428 · 2024-01-17T23:46:01.000+11:00
diff --git a/SpanConverter.php b/SpanConverter.php
@@ -173,7 +173,7 @@ private function convertSpan(SpanDataInterface $span): Span
             $pSpan->getLinks()[] = $pLink = new Link();
             $pLink->setTraceId($this->serializer->serializeTraceId($link->getSpanContext()->getTraceIdBinary()));
             $pLink->setSpanId($this->serializer->serializeSpanId($link->getSpanContext()->getSpanIdBinary()));
-            $pLink->setFlags($span->getContext()->getTraceFlags());
+            $pLink->setFlags($link->getSpanContext()->getTraceFlags());
             $pLink->setTraceState((string) $link->getSpanContext()->getTraceState());
             $this->setAttributes($pLink, $link->getAttributes());
         }
diff --git a/composer.json b/composer.json
@@ -19,7 +19,7 @@
   "require": {
     "php": "^7.4 || ^8.0",
     "php-http/discovery": "^1.14",
-    "open-telemetry/gen-otlp-protobuf": "^1.0",
+    "open-telemetry/gen-otlp-protobuf": "^1.1",
     "open-telemetry/api": "^1.0",
     "open-telemetry/sdk": "^1.0"
   },

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ private function convertSpan(SpanDataInterface $span): Span`
`173`	`173`	`$pSpan->getLinks()[] = $pLink = new Link();`
`174`	`174`	`$pLink->setTraceId($this->serializer->serializeTraceId($link->getSpanContext()->getTraceIdBinary()));`
`175`	`175`	`$pLink->setSpanId($this->serializer->serializeSpanId($link->getSpanContext()->getSpanIdBinary()));`
`176`		`- $pLink->setFlags($span->getContext()->getTraceFlags());`
	`176`	`+ $pLink->setFlags($link->getSpanContext()->getTraceFlags());`
`177`	`177`	`$pLink->setTraceState((string) $link->getSpanContext()->getTraceState());`
`178`	`178`	`$this->setAttributes($pLink, $link->getAttributes());`
`179`	`179`	`}`