Test coverage: use-link-handler

Author: RoyEJohnson

src/app/components/shell/router-helpers/use-link-handler.ts

@@ -39,7 +39,7 @@ export default function useLinkHandler() {
         (path: Location['href'], state: State = {x: 0, y: 0}) => {
             let adjustedPath = linkHelper.stripOpenStaxDomain(path);
 
-            if (portal && !adjustedPath.startsWith(`/${portal}`)) {
+            if (portal) {
                 adjustedPath = `/${portal}${adjustedPath}`;
             }
             navigate(adjustedPath, state);

test/src/components/shell/use-link-handler.test.tsx

@@ -7,6 +7,11 @@ import useLinkHandler, {
 } from '~/components/shell/router-helpers/use-link-handler';
 import linkHelper from '~/helpers/link';
 import {useNavigate, MemoryRouter} from 'react-router-dom';
+import * as PC from '~/contexts/portal';
+
+// @ts-expect-error does not exist on
+const {routerFuture} = global;
+const saveError = console.error;
 
 jest.mock('react-router-dom', () => ({
     ...jest.requireActual('react-router-dom'),
@@ -36,7 +41,7 @@ describe('use-link-handler', () => {
         return <a href="https://dev.openstax.org/some-url" onClick={onClick} />;
     };
     const Component = (props: Parameters<typeof InnerComponent>[0]) => (
-        <MemoryRouter initialEntries={['/']}>
+        <MemoryRouter initialEntries={['/']} future={routerFuture}>
             <InnerComponent {...props} />
         </MemoryRouter>
     );
@@ -77,10 +82,32 @@ describe('use-link-handler', () => {
         (useNavigate as jest.Mock).mockReturnValue(navigate);
 
         render(<Component />);
+        console.error = jest.fn();
         await user.click(screen.getByRole('link'));
+        console.error = saveError;
         expect(notPrevented).not.toBeCalled();
         expect(navigate).toBeCalledWith('whatever', {x: 0, y: 0});
     });
+    it('rewrites URL when in portal', async () => {
+        const navigate = jest.fn();
+        const el = document.createElement('a');
+
+        jest.spyOn(linkHelper, 'validUrlClick').mockReturnValue(el);
+        jest.spyOn(linkHelper, 'stripOpenStaxDomain').mockReturnValue(
+            '/whatever'
+        );
+        const spyPC = jest.spyOn(PC, 'default').mockReturnValueOnce({portal: 'a-portal', setPortal: jest.fn()});
+
+        (useNavigate as jest.Mock).mockReturnValue(navigate);
+
+        render(<Component />);
+        console.error = jest.fn();
+        await user.click(screen.getByRole('link'));
+        console.error = saveError;
+        expect(notPrevented).not.toBeCalled();
+        expect(navigate).toBeCalledWith('/a-portal/whatever', {x: 0, y: 0});
+        spyPC.mockRestore();
+    });
     it('calls piTracker if available', async () => {
         type WindowWithPiTracker = (typeof window) & {
             piTracker: (path: string) => void;
@@ -123,7 +150,9 @@ describe('use-link-handler', () => {
         (useNavigate as jest.Mock).mockReturnValue(navigate);
 
         render(<Component />);
+        console.error = jest.fn();
         await user.click(screen.getByRole('link'));
+        console.error = saveError;
         expect(notPrevented).not.toBeCalled();
         expect(navigate).not.toBeCalled();
     });
@@ -144,7 +173,9 @@ describe('use-link-handler', () => {
         (useNavigate as jest.Mock).mockReturnValue(navigate);
 
         render(<Component />);
+        console.error = jest.fn();
         await user.click(screen.getByRole('link'));
+        console.error = saveError;
         expect(notPrevented).not.toBeCalled();
         expect(navigate).not.toBeCalled();
     });