Allow for possible lack of data

Author: RoyEJohnson

src/app/pages/renewal-form/renewal-form.js

@@ -176,7 +176,7 @@ function EnsureLoggedIn() {
     const [adoptionInfo, setAdoptionInfo] = React.useState(defaultMsg);
 
     React.useEffect(
-        () => adoptionsPromise.then(setAdoptionInfo),
+        () => adoptionsPromise.then((info) => info && setAdoptionInfo(info)),
         []
     );
 

src/app/pages/renewal-form/salesforce-data.ts

@@ -5,20 +5,23 @@ const asUSD = new Intl.NumberFormat('en-US', {
     currency: 'USD'
 });
 
-
 function createThanksStatement({adoptions}: AdoptionData) {
     const firstYear = Math.min(...adoptions.map((a) => a.baseYear));
     const sumStudents = adoptions
         .map((a) => a.students)
         .filter((s): s is Exclude<typeof s, null> => s !== null)
         .reduce((a, b) => a + b);
-    const sumSavings = adoptions
-        .map((a) => a.savings)
-        .reduce((a, b) => a + b);
+    const sumSavings = adoptions.map((a) => a.savings).reduce((a, b) => a + b);
 
-    return `Thanks for being an adopter of our books since ${firstYear}.
-    You've impacted ${sumStudents} students, saving them a total of
-    ${asUSD.format(sumSavings)}.`;
+    return (
+        (firstYear
+            ? `Thanks for being an adopter of our books since ${firstYear}. `
+            : '') +
+        (sumSavings
+            ? `You've impacted ${sumStudents} students, saving them a total of
+    ${asUSD.format(sumSavings)}.`
+            : '')
+    );
 }
 
 export default adoptionPromise.then(createThanksStatement);