-
Notifications
You must be signed in to change notification settings - Fork 29
OPRUN-3962: Add structure to allow move the orgin tests using OTE #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPRUN-3962: Add structure to allow move the orgin tests using OTE #383
Conversation
@camilamacedo86: This pull request references OPRUN-3962 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5893e18
to
039e348
Compare
@camilamacedo86: This pull request references OPRUN-3962 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@camilamacedo86: This pull request references OPRUN-3962 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@camilamacedo86: This pull request references OPRUN-3962 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@camilamacedo86: This pull request references OPRUN-3962 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8bf2366
to
c7c197d
Compare
c7c197d
to
37e02c1
Compare
@camilamacedo86 thanks. I will review it. |
I will finish review tomorrow because I need to take more time review it. |
@camilamacedo86: This pull request references OPRUN-3962 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f8cf6f6
to
bd7b074
Compare
Hi @kuiwang02
Thank you for checking the PR! 😊 I needed to change it because now we can use Go 1.24. So, I rebased it and also renamed the bin to match the others — like in this example: https://github.com/openshift/origin/pull/29949/files. Please note: this PR only adds the bin. There are no tests. I didn’t understand the concern, since we are not using OCP, mocks, or special test cases here. Thanks a lot for your help and understanding! 🙏 |
bd7b074
to
52143f7
Compare
@camilamacedo86: This pull request references OPRUN-3962 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check in the tests/extension/vendor
folder? I understand that we are checking in the top level vendor folder for this repo, but that's probably because of some downstream-ing process quirks.
It'll be cleaner to have the vendor folder git ignored, and then the Make recipes to include go mod vendor
before building the binary, if possible
af69a53
to
a43dca9
Compare
@camilamacedo86: This pull request references OPRUN-3962 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a43dca9
to
2c1599d
Compare
@anik120 Can you please unblock this PR? We must have the vendor so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 makes sense, thanks for checking that and confirming.
/lgtm
reminder: |
2c1599d
to
b7d9493
Compare
This commit introduces a binary and supporting structure to enable the execution of OpenShift origin (olmv1) tests using the Open Test Environment (OTE). It lays the groundwork for moving origin test in openshift/origin to be executed from this repository using OTE.
b7d9493
to
c03a226
Compare
/test okd-scos-e2e-aws-ovn |
@camilamacedo86: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, camilamacedo86, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] Distgit: ose-olm-catalogd |
[ART PR BUILD NOTIFIER] Distgit: ose-olm-operator-controller |
…reachable target call
…reachable target call
Description
This commit introduces a binary and supporting structure to enable the
execution of OpenShift origin (olmv1) tests using the Open Test Environment (OTE).
It lays the groundwork for moving origin test in openshift/origin to
be executed from this repository using OTE.
Checklist from https://docs.google.com/document/d/1cFZj9QdzW8hbHc3H0Nce-2xrJMtpDJrwAse9H7hLiWk/edit?tab=t.0
Local Tests
./my-component-tests run-suite
./my-component-tests run-test -n
Blocks