Skip to content

Commit 4ba649b

Browse files
committed
hack: Drop /tmp mounts
Eric points out potential issues with relabeling /tmp [1], which is shared by several system-level consumers. For the Bazel script, the /tmp mount is just since c483f59 (Move bazel build tarball test to prow, 2018-08-08, #117), so we can drop it to return to our previous approach. The Terraform container seems to run fine without /tmp as well, although there's no clear history to point to on this front because we used to use Bazel for this. See b8a9bbc (Remove bazel from test process, 2018-08-01, #97). [1]: #174 (comment)
1 parent 0133912 commit 4ba649b

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

hack/test-bazel-build-tarball.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ else
66
docker run --rm \
77
--env IS_CONTAINER=TRUE \
88
--volume "${PWD}:${PWD}:z" \
9-
--volume /tmp:/tmp:z \
109
--workdir "${PWD}" \
1110
quay.io/coreos/tectonic-builder:bazel-v0.3 \
1211
./hack/test-bazel-build-tarball.sh

hack/tf-fmt.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ else
88
docker run --rm \
99
--env IS_CONTAINER=TRUE \
1010
--volume "${PWD}:${PWD}:ro,z" \
11-
--volume /tmp:/tmp:z \
1211
--workdir "${PWD}" \
1312
quay.io/coreos/terraform-alpine:v0.11.7 \
1413
./hack/tf-fmt.sh

0 commit comments

Comments
 (0)