scripts/maintenance: Fix dates (tomorrow vs. today, etc.)

tag-aws.sh is using grafiti, whose tagPatterns takes jq expressions
[1].  We've been using strftime since the script landed in 82bdd9f
(installer/scripts: AWS tag and delete scripts, 2017-06-28,
coreos/tectonic-installer#1239).  jq's strftime doesn't respect your
configured $TZ, but the coming jq 1.6 will add strflocaltime which
does [2,3].  jq uses seconds since the epoch for date-time values [4].
You can test the new construct with:

  $ jq --null-input --raw-output 'now + 24*60*60 | strftime("%Y-%m-%d")'
  2018-07-27

-d is not part of the POSIX date specification [5], but it (and the
'tomorrow' value) are supported by GNU Coreutils [6,7].  We've been
using -d in clean-aws.sh for a while now, so this is now a new
dependency.

I've also dropped date_override, since we can just set date_string
directly.  And I've shuffled around some of the conditionals to avoid
calling the 'date' and 'jq' commands needlessly when --date-override
is set.

I've also replaced the multiple date calls in clean-aws.sh with a
single call to jq.  jq was already a required dependency for this
script, and only needing a single child process is much faster:

  $ time for i in $(seq 100); do A="$(jq --null-input '[["%Y-%m-%d", "%Y-%-m-%-d", "%m-%d-%Y", "%m-%-d-%-Y", "%-m-%-d-%-Y", "%d-%m-%Y", "%d-%-m-%-Y"][] | . as $format | [now, now - 24*60*60][] | strftime($format)]')"; done

  real   0m0.256s
  user   0m0.186s
  sys    0m0.077s
  $ time for i in $(seq 100); do A="$(date "+%Y-%m-%d" -d "-1 day")\",\"$(date "+%Y-%-m-%-d" -d "-1 day")\",\"$(date "+%m-%-d-%-Y" -d "-1 day")\",\"$(date "+%-m-%-d-%-Y" -d "-1 day")\",\"$(date "+%d-%m-%-Y" -d "-1 day")\",\"$(date "+%d-%-m-%-Y" -d "-1 day")\",\"$(date +%m-%d-%Y)\",\"$(date +%d-%m-%Y)\",\"$(date +%d-%-m-%Y)\",\"$(date +%Y-%m-%d)\",\"$(date +%Y-%-m-%-d)"; done

  real   0m1.358s
  user   0m0.604s
  sys    0m0.832s

And that's despite the fact that the old approach skipped some formats
for today (e.g. %m-%-d-%-Y had been only used to format yesterday).

The plethora of date formats are mostly from 3995263 (ci: add more
date format when grafiti apply the cleanning, 2017-09-12,
coreos/tectonic-installer#1890), although we've had some since
82bdd9f.  The motivation seems to be matching human-generated tags
[8], which are less reliably formatted.

[1]: https://github.com/coreos/grafiti/blob/89a8bc92ad7fde49cd3dd78197c6b3616a857f36/README.md#configure-grafiti
[2]: https://github.com/stedolan/jq/wiki/FAQ
[3]: jqlang/jq@06f2060
[4]: https://stedolan.github.io/jq/manual/v1.5/#Dates
[5]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/date.html
[6]: https://www.gnu.org/software/coreutils/manual/html_node/Options-for-date.html
[7]: https://www.gnu.org/software/coreutils/manual/html_node/Relative-items-in-date-strings.html
[8]: coreos/tectonic-installer#1890 (comment)

Author: wking

scripts/maintenance/clean-aws.sh

@@ -27,11 +27,10 @@ Options:
   --tag-file        A file containing a TagFilter list. See the AWS Resource Group
                     Tagging API 'TagFilter' documentation for file structure.
 
-  --date-override   (optional) Date of the format YYYY-MM-DD that overrides the
-                    default tag value of today's date. This script tags resources
-                    with 'expirationDate: some-date-string', where some-date-string
-                    is replaced with either the following days' date or date-override.
-                    Only use if --tag-file is not used.
+  --date-override   (optional) Date of the format YYYY-MM-DD to delete resources
+                    tagged with 'expirationDate: some-date-string'.  By default,
+                    this script deletes resources which expired yesterday or
+                    today.  Not compatible with --tag-file.
 
   --dry-run         (optional) If set, grafiti will only do a dry run, i.e. not
                     delete any resources.
@@ -44,7 +43,7 @@ version=
 region=
 config_file=
 tag_file=
-date_override=
+date_string=
 dry_run=
 
 while [ $# -gt 0 ]; do
@@ -73,7 +72,7 @@ while [ $# -gt 0 ]; do
       shift
     ;;
     --date-override)
-      date_override="${2:-}"
+      date_string="[\"${2:-}\"]"
       shift
     ;;
     --dry-run)
@@ -112,7 +111,7 @@ if [ -z "$version" ]; then
   exit 1
 fi
 
-if [ -n "$tag_file" ] && [ -n "$date_override" ]; then
+if [ -n "$tag_file" ] && [ -n "$date_string" ]; then
   echo "Cannot use both --tag-file and --date-override flags simultaneously." >&2
   exit 1
 fi
@@ -132,16 +131,12 @@ fi
 if [ -n "$tag_file" ]; then
   cat "$tag_file" >"$tmp_dir/tag.json"
 else
-  date_string="$(date "+%Y-%m-%d" -d "-1 day")\",\"$(date "+%Y-%-m-%-d" -d "-1 day")\",
-  \"$(date "+%m-%-d-%-Y" -d "-1 day")\",\"$(date "+%-m-%-d-%-Y" -d "-1 day")\",\"$(date "+%d-%m-%-Y" -d "-1 day")\",
-  \"$(date "+%d-%-m-%-Y" -d "-1 day")\",\"$(date +%m-%d-%Y)\",\"$(date +%d-%m-%Y)\",
-  \"$(date +%d-%-m-%Y)\",\"$(date +%Y-%m-%d)\",\"$(date +%Y-%-m-%-d)"
-  if [ -n "$date_override" ]; then
-  	date_string="$date_override"
+  if [ -z "$date_string" ]; then
+    date_string="$(jq --null-input '[["%Y-%m-%d", "%Y-%-m-%-d", "%m-%d-%Y", "%m-%-d-%-Y", "%-m-%-d-%-Y", "%d-%m-%Y", "%d-%-m-%-Y"][] | . as $format | [now, now - 24*60*60][] | strftime($format)]')"
   fi
 
   cat <<EOF >"$tmp_dir/tag.json"
-{"TagFilters":[{"Key":"expirationDate","Values":["${date_string}"]}]}
+{"TagFilters":[{"Key":"expirationDate","Values":${date_string}}]}
 EOF
 fi
 

scripts/maintenance/tag-aws.sh

@@ -4,7 +4,7 @@ usage() {
   cat <<EOF
 
 $(basename "$0") tags AWS resources with 'expirationDate: some-date-string',
-defaulting to the following days' date, and excludes all resources tagged with
+defaulting to tomorrow's date, and excludes all resources tagged with
 tag keys/values specified in an 'exclude' file. Requires that 'docker' is
 installed.
 
@@ -33,9 +33,9 @@ Options:
   --end-hour        Integer hour to end looking at CloudTrail logs. Defaults to 1.
 
   --date-override   (optional) Date of the format YYYY-MM-DD that overrides the
-                    default tag value of today's date. This script tags resources
+                    default tag value of tomorrow's date. This script tags resources
                     with 'expirationDate: some-date-string', where some-date-string
-                    is replaced with either the following days' date or date-override.
+                    is replaced with either tomorrow's date or date-override.
 
   --dry-run         (optional) If set, grafiti will only do a dry run, i.e. not tag
                     any resources.
@@ -48,7 +48,7 @@ version=
 region=
 config_file=
 exclude_file=
-date_override=
+date_string=
 start_hour=8
 end_hour=1
 dry_run=
@@ -87,7 +87,7 @@ while [ $# -gt 0 ]; do
       shift
     ;;
     --date-override)
-      date_override="${2:-}"
+      date_string="\\\"${2:-}\\\""
       shift
     ;;
     --dry-run)
@@ -134,14 +134,13 @@ fi
 set -e
 
 # Tag all resources present in CloudTrail over the specified time period with the
-# following day's date as default, or with the DATE_VALUE_OVERRIDE value.
+# today's date as default, or with the --date-override value.
 # Format YYYY-MM-DD.
 tmp_dir="$(readlink -m "$(mktemp -d tag-aws-XXXXXXXXXX)")"
 trap 'rm -rf "$tmp_dir"; exit' EXIT
 
-date_string='now|strftime(\"%Y-%m-%d\")'
-if [ -n "$date_override" ]; then
-	date_string='\"'"${date_override}"'\"'
+if [ -z "$date_string" ]; then
+	date_string='(now + 24*60*60|strftime(\"%Y-%m-%d\"))'
 fi
 
 # Configure grafiti to tag all resources created between START_HOUR and END_HOUR's

scripts/maintenance/tag-route53-hosted-zones.sh

@@ -14,15 +14,15 @@ Options:
   --force           Override user input prompts. Useful for automation.
 
   --date-override   (optional) Date of the format YYYY-MM-DD that overrides the
-                    default tag value of today's date. This script tags resources
+                    default tag value of tomorrow's date. This script tags resources
                     with 'expirationDate: some-date-string', where some-date-string
-                    is replaced with either the following days' date or date-override.
+                    is replaced with either tomorrow's date or date-override.
 
 EOF
 }
 
 force=
-date_override=
+date_string=
 
 while [ $# -gt 0 ]; do
   case $1 in
@@ -34,7 +34,7 @@ while [ $# -gt 0 ]; do
       force=true
     ;;
     --date-override)
-      date_override="${2:-}"
+      date_string="${2:-}"
       shift
     ;;
     *)
@@ -53,11 +53,10 @@ fi
 set -e
 
 # Tag all Route53 hosted zones that do not already have a tag with the same keys,
-# in this case 'expirationDate', with today's date as default, or
-# with the DATE_VALUE_OVERRIDE value. Format YYYY-MM-DD.
-date_string="$(date "+%Y-%m-%d")"
-if [ -n "$date_override" ]; then
-	date_string="${date_override}"
+# in this case 'expirationDate', with tomorrow's date as default, or
+# with the --date-override value. Format YYYY-MM-DD.
+if [ -z "$date_string" ]; then
+  date_string="$(date -d tomorrow '+%Y-%m-%d')"
 fi
 
 tags="[{\"Key\":\"expirationDate\",\"Value\":\"$date_string\"}]"