Merge pull request #4073 from jaellio/e2eIgnoreNamespace

feat(e2e): ensures namespace ignore label takes precedence

Author: jaellio

tests/e2e/e2e_ignore_namespace_test.go

@@ -0,0 +1,76 @@
+package e2e
+
+import (
+	"context"
+	"time"
+
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	corev1 "k8s.io/api/core/v1"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+	"github.com/openservicemesh/osm/pkg/constants"
+	. "github.com/openservicemesh/osm/tests/framework"
+)
+
+var _ = OSMDescribe("Ignore Namespaces",
+	OSMDescribeInfo{
+		Tier:   1,
+		Bucket: 2,
+	},
+	func() {
+		Context("Ignore Label", func() {
+			const ignoreNs = "ignore"
+
+			It("Tests the ignore label on a namespace disables sidecar injection", func() {
+				// Install OSM
+				installOpts := Td.GetOSMInstallOpts()
+				installOpts.EnablePermissiveMode = true
+				Expect(Td.InstallOSM(installOpts)).To(Succeed())
+
+				// Create test NS in mesh with ignore label
+				Expect(Td.CreateNs(ignoreNs, map[string]string{constants.IgnoreLabel: "true"})).To(Succeed())
+
+				// Add test NS to mesh with sidecar injection enabled
+				Expect(Td.AddNsToMesh(true, ignoreNs)).To(Succeed())
+
+				By("Ensuring a pod is not injected with a sidecar when added to namespace the ignore, and sidecar injection labels set")
+
+				// Get simple Pod definitions
+				svcAccDef, podDef, svcDef, err := Td.SimplePodApp(
+					SimplePodAppDef{
+						Name:      "pod1",
+						Namespace: ignoreNs,
+						Command:   []string{"/bin/bash", "-c", "--"},
+						Args:      []string{"while true; do sleep 30; done;"},
+						Image:     "songrgg/alpine-debug",
+						Ports:     []int{80},
+						OS:        Td.ClusterOS,
+					})
+				Expect(err).NotTo(HaveOccurred())
+
+				_, err = Td.CreateServiceAccount(ignoreNs, &svcAccDef)
+				Expect(err).NotTo(HaveOccurred())
+				pod, err := Td.CreatePod(ignoreNs, podDef)
+				Expect(err).NotTo(HaveOccurred())
+				_, err = Td.CreateService(ignoreNs, svcDef)
+				Expect(err).NotTo(HaveOccurred())
+
+				Expect(Td.WaitForPodsRunningReady(ignoreNs, 90*time.Second, 1, nil)).To(Succeed())
+
+				pod, err = Td.Client.CoreV1().Pods(ignoreNs).Get(context.Background(), pod.Name, v1.GetOptions{})
+				Expect(err).NotTo(HaveOccurred())
+
+				Expect(hasSidecar(pod.Spec.Containers)).To(BeFalse())
+			})
+		})
+	})
+
+func hasSidecar(containers []corev1.Container) bool {
+	for _, container := range containers {
+		if container.Name == constants.EnvoyContainerName {
+			return true
+		}
+	}
+	return false
+}