Skip to content

Remove deprecated settings from code #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
Tracked by #5031
DarshitChanpura opened this issue Mar 13, 2024 · 1 comment
Open
1 task
Tracked by #5031

Remove deprecated settings from code #4117

DarshitChanpura opened this issue Mar 13, 2024 · 1 comment
Labels
good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v3.0.0

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Mar 13, 2024

There are some lingering references to deprecated settings with messages that they will be deprecated in specific version, and these versions have long since released.

Example:
These audit config settings had been marked for removal in 2.0.0.0 but are still around in the code:

public static final List<String> DEPRECATED_KEYS = ImmutableList.of(

Expected outcome:

  • All deprecated settings that should be removed, have been removed
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Mar 13, 2024
@cwperks
Copy link
Member

cwperks commented Mar 18, 2024

[Triage] @DarshitChanpura Thank you for filing this issue. Since the settings are currently in the code, would it make sense to update the message on the 2.x line and remove the deprecated settings on main to be released in the 3.x line?

@peternied peternied added the good first issue These are recommended starting points for newcomers looking to make their first contributions. label Mar 18, 2024
@cwperks cwperks added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are recommended starting points for newcomers looking to make their first contributions. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v3.0.0
Projects
None yet
Development

No branches or pull requests

3 participants