Fixed rest status for the replication action failure with DLS/FLS and (#1677)

updated test cases to capture status code

Signed-off-by: Sai Kumar <[email protected]>

Author: sai-karanam

src/main/java/org/opensearch/security/configuration/DlsFlsValveImpl.java

@@ -49,6 +49,7 @@
 import org.opensearch.common.util.concurrent.ThreadContext;
 import org.opensearch.common.xcontent.NamedXContentRegistry;
 import org.opensearch.index.query.ParsedQuery;
+import org.opensearch.rest.RestStatus;
 import org.opensearch.search.DocValueFormat;
 import org.opensearch.search.aggregations.AggregationBuilder;
 import org.opensearch.search.aggregations.BucketOrder;
@@ -255,7 +256,8 @@ public boolean invoke(String action, ActionRequest request, final ActionListener
         }
 
         if(action.contains("plugins/replication")) {
-            listener.onFailure(new OpenSearchSecurityException("Cross Cluster Replication is not supported when FLS or DLS or Fieldmasking is activated"));
+            listener.onFailure(new OpenSearchSecurityException("Cross Cluster Replication is not supported when FLS or DLS or Fieldmasking is activated",
+                    RestStatus.FORBIDDEN));
             return false;
         }
 

src/test/java/org/opensearch/security/dlic/dlsfls/CCReplicationTest.java

@@ -59,6 +59,7 @@
 import org.opensearch.plugins.ActionPlugin;
 import org.opensearch.plugins.Plugin;
 import org.opensearch.repositories.RepositoriesService;
+import org.opensearch.rest.RestStatus;
 import org.opensearch.script.ScriptService;
 import org.opensearch.security.OpenSearchSecurityPlugin;
 import org.opensearch.security.support.ConfigConstants;
@@ -221,6 +222,7 @@ public void testReplication() throws Exception {
             log.warn(ex.getMessage());
             Assert.assertNotNull(ex);
             Assert.assertTrue(ex.getMessage().contains("Cross Cluster Replication is not supported when FLS or DLS or Fieldmasking is activated"));
+            Assert.assertEquals(ex.status(), RestStatus.FORBIDDEN);
         }
 
         try (Node node = new PluginAwareNode(false, tcSettings, Netty4Plugin.class, OpenSearchSecurityPlugin.class, MockReplicationPlugin.class).start()) {
@@ -230,6 +232,7 @@ public void testReplication() throws Exception {
             log.warn(ex.getMessage());
             Assert.assertNotNull(ex);
             Assert.assertTrue(ex.getMessage().contains("Cross Cluster Replication is not supported when FLS or DLS or Fieldmasking is activated"));
+            Assert.assertEquals(ex.status(), RestStatus.FORBIDDEN);
         }
 
         try (Node node = new PluginAwareNode(false, tcSettings, Netty4Plugin.class, OpenSearchSecurityPlugin.class, MockReplicationPlugin.class).start()) {
@@ -239,6 +242,7 @@ public void testReplication() throws Exception {
             log.warn(ex.getMessage());
             Assert.assertNotNull(ex);
             Assert.assertTrue(ex.getMessage().contains("Cross Cluster Replication is not supported when FLS or DLS or Fieldmasking is activated"));
+            Assert.assertEquals(ex.status(), RestStatus.FORBIDDEN);
         }
 
         try (Node node = new PluginAwareNode(false, tcSettings, Netty4Plugin.class, OpenSearchSecurityPlugin.class, MockReplicationPlugin.class).start()) {