Skip to content

Commit 104565a

Browse files
djindjicgithub-actions[bot]
authored andcommitted
Toggle all rules button on detector edit page (#239)
* toggle all rules button on detector edit page Signed-off-by: Aleksandar Djindjic <[email protected]> * adding toggle all - adds hidden button into table Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 24a5dab)
1 parent 40a75d6 commit 104565a

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

cypress/integration/1_detectors.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ describe('Detectors', () => {
222222
cy.contains('tr', 'USB Device Plugged').within(() => {
223223
// Of note, timeout can sometimes work instead of wait here, but is very unreliable from case to case.
224224
cy.wait(1000);
225-
cy.get('button').eq(0).click();
225+
cy.get('button').eq(1).click();
226226
});
227227

228228
// Save changes
@@ -246,7 +246,7 @@ describe('Detectors', () => {
246246
// Toggle single search result to checked
247247
cy.contains('tr', 'USB Device Plugged').within(() => {
248248
cy.wait(2000);
249-
cy.get('button').eq(0).click({ force: true });
249+
cy.get('button').eq(1).click({ force: true });
250250
});
251251

252252
// Save changes

public/pages/Detectors/components/UpdateRules/UpdateRules.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,11 @@ export const UpdateDetectorRules: React.FC<UpdateDetectorRulesProps> = (props) =
166166
}
167167
};
168168

169+
const onAllRulesToggle = (isActive: boolean) => {
170+
setCustomRuleItems(customRuleItems.map((rule) => ({ ...rule, active: isActive })));
171+
setPrePackagedRuleItems(prePackagedRuleItems.map((rule) => ({ ...rule, active: isActive })));
172+
};
173+
169174
const onCancel = useCallback(() => {
170175
props.history.replace({
171176
pathname: `${ROUTES.DETECTOR_DETAILS}/${detectorId}`,
@@ -216,6 +221,7 @@ export const UpdateDetectorRules: React.FC<UpdateDetectorRulesProps> = (props) =
216221
loading={loading}
217222
ruleItems={ruleItems}
218223
onRuleActivationToggle={onToggle}
224+
onAllRulesToggled={onAllRulesToggle}
219225
/>
220226

221227
<EuiSpacer size="xl" />

0 commit comments

Comments
 (0)