Skip to content

[BUG] #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fxieatlassian opened this issue Apr 29, 2025 · 0 comments
Open

[BUG] #1093

fxieatlassian opened this issue Apr 29, 2025 · 0 comments
Labels
bug Something isn't working untriaged

Comments

@fxieatlassian
Copy link

What is the bug?
A clear and concise description of the bug.
It looks like this is a bug in the LTR plugin, leading to bad request of params is empty because it's required but doesn't serialise if it is empty. opensearch-learning-to-rank-base/src/main/java/com/o19s/es/ltr/query/StoredLtrQueryBuilder.java at main · opensearch-project/opensearch-learning-to-rank-base makes the params mandatory but opensearch-learning-to-rank-base/src/main/java/com/o19s/es/ltr/query/StoredLtrQueryBuilder.java at main · opensearch-project/opensearch-learning-to-rank-base doesn’t serialize params if they are empty or null.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. send a search request with filter and sltr block, but empty map for the params
  2. opensearch will return a bad request

What is the expected behavior?
the expected behaviour is a normal search request, it should return a 200 OK.

What is your host/environment?

  • OS: Java
  • Version: 2
  • Plugins: LTR

Do you have any screenshots?

Image

Image

Do you have any additional context?
Add any other context about the problem.

@fxieatlassian fxieatlassian added bug Something isn't working untriaged labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

1 participant