Skip to content

[Enhancement] consolidate build and assemble into single unified process #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tianleh opened this issue Mar 25, 2022 · 0 comments
Open
Labels
enhancement New Enhancement proposal Proposal and RFC to the community

Comments

@tianleh
Copy link
Member

tianleh commented Mar 25, 2022

Introduction

Inspired by #1812 (comment) and some follow up discussions with @dblock , I am summarizing the proposal to consolidate build and assemble into single unified process.

Current bundle artifact generation process consists of two steps.

The first step is build https://github.com/opensearch-project/opensearch-build/blob/main/build.sh It will take an input manifest as input and output a build manifest and related component artifacts. This is a screenshot of the output structure.

Screen Shot 2022-03-24 at 4 22 42 PM

The second step is assemble https://github.com/opensearch-project/opensearch-build/blob/main/assemble.sh It will take the build manifest of previous build step and output the bundle manifest as well as the bundle artifact. This is a screenshot of the output structure.

Screen Shot 2022-03-24 at 4 29 23 PM

Proposal

The proposal is to have a single process to perform the build and assemble work together. (e.g roll assemble into build) In this way, the intermediate output doesn't need to be persisted. (e.g build manifest) This will also simplify the current folder structures under the project root by removing both build and dist.

Call out

  1. ARM build is cross platform.
  2. Integ test needs the build manifest. https://github.com/opensearch-project/opensearch-build/blob/c96aff001188af8878465761302669dd464dbf0a/src/test_workflow/integ_test/integ_test_suite_opensearch_dashboards.py We may need to remove such dependency.
@zelinh zelinh added enhancement New Enhancement proposal Proposal and RFC to the community labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement proposal Proposal and RFC to the community
Projects
None yet
Development

No branches or pull requests

2 participants