Skip to content

Allow S3 uploading of index.yml file besides builds/dist #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianleh opened this issue Feb 6, 2022 · 3 comments · Fixed by #1620
Closed

Allow S3 uploading of index.yml file besides builds/dist #1601

tianleh opened this issue Feb 6, 2022 · 3 comments · Fixed by #1620
Assignees
Labels
enhancement New Enhancement

Comments

@tianleh
Copy link
Member

tianleh commented Feb 6, 2022

Is your feature request related to a problem? Please describe

While working on supporting latest in url, we are following the suggestion to #1569 (comment) to upload an index.yml file which contains the latest build number.

However, as documented in #1569 (comment), we identify that there is AmazonS3Exception when uploading index.yml file. Looks like the IAM role opensearch-bundle is not allowed to perform such uploading. The complete log is in this Jenkins run http://jenki-jenki-fpgmrv2ryxko-1366042710.us-east-1.elb.amazonaws.com/job/Playground/job/tianleh-distribution-url-latest/7/console

Describe the solution you'd like

Allow opensearch-bundle to upload index.yml file under $BUCKET/distribution-build-opensearch/1.2.4

Describe alternatives you've considered

No response

Additional context

No response

@tianleh tianleh added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Feb 6, 2022
@tianleh
Copy link
Member Author

tianleh commented Feb 6, 2022

@peternied Could infra team help prioritize this while I am working on #1569?

CC @dblock @seraphjiang @bbarani @xinlamzn for visibility

@dblock
Copy link
Member

dblock commented Feb 7, 2022

@tianleh I believe this should be added to https://github.com/opensearch-project/opensearch-build/blob/main/deployment/lib/identities.ts#L40 as needed

@tianleh
Copy link
Member Author

tianleh commented Feb 14, 2022

Decided to use index.json instead of index.yml #1569 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants