Skip to content

[BUG] Missing necessary license, description, developer information in maven pom #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterzhuamazon opened this issue Mar 18, 2025 · 6 comments · Fixed by #732
Closed
Labels

Comments

@peterzhuamazon
Copy link
Member

[BUG] Missing necessary license, description, developer information in maven pom

[ERROR] 
[ERROR] Nexus Staging Rules Failure Report
[ERROR] ==================================
[ERROR] 
[ERROR] Repository "orgopensearch-1259" failures
[ERROR]   Rule "pom-staging" failures
[ERROR]     * Invalid POM: /org/opensearch/opensearch-geospatial/3.0.0.0-alpha1/opensearch-geospatial-3.0.0.0-alpha1.pom: Project description missing, License information missing, Developer information missing
[ERROR]     * Invalid POM: /org/opensearch/geospatial-client/3.0.0.0-alpha1/geospatial-client-3.0.0.0-alpha1.pom: License information missing, Developer information missing
[ERROR] 
  1. https://github.com/opensearch-project/geospatial/blob/main/build.gradle#L47 this needs to be set as true
  2. Add necessary information just like in Job Scheduler repo: https://github.com/opensearch-project/job-scheduler/blob/main/spi/build.gradle#L127-L157
  3. Verify pom file for opensearch-geospatial and geospatial-client pom in .m2 after running ./gradlew publishNebulaPublicationToMavenLocal

Thanks.

@peterzhuamazon
Copy link
Member Author

Adding @will-hwang as we just discussed this offline.

cc: @gaiksaya @zelinh

Thanks.

@zelinh
Copy link
Member

zelinh commented Mar 19, 2025

You can also valide the Pom by running ./gradlew validatePom which should have included ./gradlew validateNebulaPom

@will-hwang
Copy link
Contributor

will-hwang commented Mar 21, 2025

@peterzhuamazon is ./publishNebulaPublicationToMavenLocal a hard requirement? ./gradlew publishToMavenLocal would achieve the same outcome with minimal code change

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Mar 21, 2025

./gradlew publishToMavenLocal is good. The nebula part I have is just utilizing an existing task with no changes.

Thanks.

@peterzhuamazon
Copy link
Member Author

Note with above changes you would need to also update the publish maven snapshot github workflow, and scripts/build.sh to have the same updates.

@will-hwang
Copy link
Contributor

can you checkout this PR and test everything is working as expected?
#732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants