Skip to content

Commit 09ea80a

Browse files
committed
fix advanced setting bugs
Signed-off-by: Fen Qin <[email protected]>
1 parent 10ab749 commit 09ea80a

File tree

2 files changed

+9
-146
lines changed

2 files changed

+9
-146
lines changed

public/components/api/search_relevance_testing_page.tsx

Lines changed: 0 additions & 144 deletions
This file was deleted.

public/components/judgment_create/judgment_create.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const JudgmentCreate: React.FC<JudgmentCreateProps> = ({ http, notificati
172172
searchConfigurationList: selectedSearchConfigs.map((config) => config.value),
173173
size,
174174
modelId,
175-
...(contextFields.length > 0 && { contextFields }),
175+
contextFields,
176176
...(tokenLimit !== 4000 && { tokenLimit: tokenLimit.toString() }),
177177
...(ignoreFailure && { ignoreFailure }),
178178
}
@@ -387,7 +387,13 @@ export const JudgmentCreate: React.FC<JudgmentCreateProps> = ({ http, notificati
387387
<EuiBadge
388388
key={field}
389389
color="hollow"
390-
onClose={() => removeContextField(field)}
390+
iconType="cross"
391+
iconSide="right"
392+
iconOnClick={() => {
393+
console.log('Removing field:', field); // For debugging
394+
removeContextField(field);
395+
}}
396+
iconOnClickAriaLabel={`Remove ${field} from context fields`}
391397
style={{ marginRight: '4px', marginBottom: '4px' }}
392398
>
393399
{field}
@@ -414,6 +420,7 @@ export const JudgmentCreate: React.FC<JudgmentCreateProps> = ({ http, notificati
414420
}}
415421
min={1000}
416422
max={500000}
423+
step={1000} // Add step value for larger increments
417424
fullWidth
418425
/>
419426
</EuiCompressedFormRow>

0 commit comments

Comments
 (0)