Skip to content

[FEATURE] Allow json5 file extensions for integration configs #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Swiddis opened this issue May 2, 2024 · 1 comment
Open

[FEATURE] Allow json5 file extensions for integration configs #1816

Swiddis opened this issue May 2, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Swiddis
Copy link
Collaborator

Swiddis commented May 2, 2024

Is your feature request related to a problem?
#1732 got started on introducing JSON5 support by adding its parsing to the config parsing, so the JSON5 support is live. But currently integrations relies on the file extension being json to find a config, which causes issues with syntax highlighters.

What solution would you like?
Add logic to try both json and json5 extensions when reading config files. Possibly with some sort of regex match?

What alternatives have you considered?
N/A

Do you have any additional context?
#1680

@Swiddis Swiddis added enhancement New feature or request good first issue Good for newcomers untriaged and removed untriaged labels May 2, 2024
@quangdutran
Copy link

Hi @Swiddis this is still up for grab right?

If it is, could you please explain why should we use regex match for the json extension? I think so far we support only the json5, extension of json so we could just simply check if the config for json file is not ok then try json5, otherwise, config is not available.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants