Skip to content

Commit f3d978b

Browse files
committed
Add i18n for acc create button
Signed-off-by: Ryan Liang <[email protected]>
1 parent 8a8bfe0 commit f3d978b

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

opensearch_dashboards.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"id": "observabilityDashboards",
3-
"version": "2.13.0.0",
4-
"opensearchDashboardsVersion": "2.13.0",
3+
"version": "3.0.0.0",
4+
"opensearchDashboardsVersion": "3.0.0",
55
"server": true,
66
"ui": true,
77
"requiredPlugins": [

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "observability-dashboards",
3-
"version": "2.13.0.0",
3+
"version": "3.0.0.0",
44
"main": "index.ts",
55
"license": "Apache-2.0",
66
"scripts": {

public/components/datasources/components/manage/accelerations/create_accelerations_flyout/create/create_acceleration_button.tsx

+6-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ import { useDirectQuery } from '../../../../../../../framework/datasources/direc
1414
import { useToast } from '../../../../../../common/toast';
1515
import { accelerationQueryBuilder } from '../visual_editors/query_builder';
1616
import { formValidator, hasError } from './utils';
17+
import {
18+
ACC_CREATE_SUBMIT_SUCCESS_MSG,
19+
ACC_CREATE_SUBMIT_FAIL_MSG,
20+
} from '../../utils/acceleration_utils';
1721

1822
interface CreateAccelerationButtonProps {
1923
accelerationFormData: CreateAccelerationForm;
@@ -51,14 +55,14 @@ export const CreateAccelerationButton = ({
5155
const status = directqueryLoadStatus.toLowerCase();
5256
if (status === DirectQueryLoadingStatus.SUCCESS) {
5357
setIsLoading(false);
54-
setToast('Create acceleration query submitted successfully!', 'success');
58+
setToast(ACC_CREATE_SUBMIT_SUCCESS_MSG, 'success');
5559
resetFlyout();
5660
} else if (
5761
status === DirectQueryLoadingStatus.FAILED ||
5862
status === DirectQueryLoadingStatus.CANCELED
5963
) {
6064
setIsLoading(false);
61-
setToast('Create acceleration query failed', 'success');
65+
setToast(ACC_CREATE_SUBMIT_FAIL_MSG, 'success');
6266
}
6367
}, [directqueryLoadStatus]);
6468

public/components/datasources/components/manage/accelerations/utils/acceleration_utils.tsx

+8
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,14 @@ export const ACC_SYNC_MSG = i18n.translate('accelerationActionOverlay.sync.descr
4040
defaultMessage: 'Syncing data may require querying all data. Do you want to continue?',
4141
});
4242

43+
export const ACC_CREATE_SUBMIT_SUCCESS_MSG = i18n.translate('acceleration.create.submitSuccess', {
44+
defaultMessage: 'Create acceleration query submitted successfully!',
45+
});
46+
47+
export const ACC_CREATE_SUBMIT_FAIL_MSG = i18n.translate('acceleration.create.submitFail', {
48+
defaultMessage: 'Create acceleration query failed',
49+
});
50+
4351
export const ACC_TABLE_ACTION_DESC = {
4452
discoverAction: i18n.translate('accelerationTable.actions.discover', {
4553
defaultMessage: 'Open in Discover',

0 commit comments

Comments
 (0)