Traces table fix for invalid date (#2399)

* add fallback for invalid date, remove duration 0 return

Signed-off-by: Adam Tackett <[email protected]>

* update cypress testing

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>

Author: TackAdam

.cypress/integration/trace_analytics_test/trace_analytics_traces.spec.js

@@ -42,7 +42,6 @@ describe('Testing traces table', () => {
 
     // test data contains output from data-prepper 0.8, which doesn't have fields denormalized
     // Trace Analytics should be able to handle the discrepancy if some fields cannot be parsed
-    cy.contains('Invalid date').should('exist');
     cy.contains('-').should('exist');
   });
 
@@ -366,6 +365,6 @@ describe('Testing traces Custom source', () => {
 
     cy.get('a.euiLink.euiLink--primary').first().click();
     cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist');
-    cy.get('.overview-content').should('contain.text', 'be0a3dceda2ecf601fd2e476fef3ee07');
+    cy.get('.overview-content').should('contain.text', 'd5bc99166e521eec173bcb7f9b0d3c43');
   });
 });

public/components/trace_analytics/components/traces/__tests__/__snapshots__/traces.test.tsx.snap

@@ -1557,6 +1557,7 @@ exports[`Traces component renders empty traces page 1`] = `
                           "align": "right",
                           "field": "latency",
                           "name": "Duration (ms)",
+                          "render": [Function],
                           "sortable": true,
                           "truncateText": true,
                         },
@@ -1632,6 +1633,7 @@ exports[`Traces component renders empty traces page 1`] = `
                             "align": "right",
                             "field": "latency",
                             "name": "Duration (ms)",
+                            "render": [Function],
                             "sortable": true,
                             "truncateText": true,
                           },
@@ -6298,6 +6300,7 @@ exports[`Traces component renders traces page 1`] = `
                           "align": "right",
                           "field": "latency",
                           "name": "Duration (ms)",
+                          "render": [Function],
                           "sortable": true,
                           "truncateText": true,
                         },
@@ -6373,6 +6376,7 @@ exports[`Traces component renders traces page 1`] = `
                             "align": "right",
                             "field": "latency",
                             "name": "Duration (ms)",
+                            "render": [Function],
                             "sortable": true,
                             "truncateText": true,
                           },

public/components/trace_analytics/components/traces/__tests__/__snapshots__/traces_table.test.tsx.snap

@@ -1876,6 +1876,7 @@ exports[`Traces table component renders traces table 1`] = `
               "align": "right",
               "field": "latency",
               "name": "Duration (ms)",
+              "render": [Function],
               "sortable": true,
               "truncateText": true,
             },
@@ -1963,6 +1964,7 @@ exports[`Traces table component renders traces table 1`] = `
                 "align": "right",
                 "field": "latency",
                 "name": "Duration (ms)",
+                "render": [Function],
                 "sortable": true,
                 "truncateText": true,
               },
@@ -2854,7 +2856,7 @@ exports[`Traces table component renders traces table 1`] = `
                               }
                             }
                             setScopeRow={false}
-                            textOnly={true}
+                            textOnly={false}
                             truncateText={true}
                           >
                             <td
@@ -2871,13 +2873,9 @@ exports[`Traces table component renders traces table 1`] = `
                                 Duration (ms)
                               </div>
                               <div
-                                className="euiTableCellContent euiTableCellContent--alignRight euiTableCellContent--truncateText"
+                                className="euiTableCellContent euiTableCellContent--alignRight euiTableCellContent--truncateText euiTableCellContent--overflowingContent"
                               >
-                                <span
-                                  className="euiTableCellContent__text"
-                                >
-                                  19.91
-                                </span>
+                                19.91
                               </div>
                             </td>
                           </EuiTableRowCell>

public/components/trace_analytics/components/traces/traces_table.tsx

@@ -122,6 +122,7 @@ export function TracesTable(props: TracesTableProps) {
           align: 'right',
           sortable: true,
           truncateText: true,
+          render: (item) => (item === 0 || item ? item : '-'),
         },
         {
           field: 'percentile_in_trace_group',

public/components/trace_analytics/requests/queries/traces_queries.ts

@@ -151,8 +151,6 @@ export const getTracesQuery = (
                 if (doc.containsKey('traceGroupFields.durationInNanos') && !doc['traceGroupFields.durationInNanos'].empty) {
                   return Math.round(doc['traceGroupFields.durationInNanos'].value / 10000) / 100.0
                 }
-
-                return 0
                 `,
                 lang: 'painless',
               },
@@ -173,7 +171,17 @@ export const getTracesQuery = (
           },
           last_updated: {
             max: {
-              field: 'traceGroupFields.endTime',
+              script: {
+                source: `
+                  if (doc.containsKey('traceGroupFields.endTime') && !doc['traceGroupFields.endTime'].empty) {
+                    return doc['traceGroupFields.endTime'].value;
+                  }
+                  if (doc.containsKey('endTime') && !doc['endTime'].empty) {
+                    return doc['endTime'].value;
+                  }
+                `,
+                lang: 'painless',
+              },
             },
           },
         },