Skip to content

[Enhancement] Bump Ansible Playbook to run OpenSearch/Dashboards 1.1.0. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterzhuamazon opened this issue Nov 1, 2021 · 8 comments · Fixed by #12
Closed

[Enhancement] Bump Ansible Playbook to run OpenSearch/Dashboards 1.1.0. #11

peterzhuamazon opened this issue Nov 1, 2021 · 8 comments · Fixed by #12
Labels
enhancement New feature or request

Comments

@peterzhuamazon
Copy link
Member

Is your feature request related to a problem? Please describe.
[Enhancement] Bump Ansible Playbook to run OpenSearch/Dashboards 1.1.0.

1.2.0 is coming and 1.1.0 already released.
We should start setting the default version to 1.1.0 for playbooks.
Also suggest having long live branches such as 1.x, 2.x so main will be the unstable branch.

Describe the solution you'd like
See above.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@peterzhuamazon peterzhuamazon added the enhancement New feature or request label Nov 1, 2021
@peterzhuamazon
Copy link
Member Author

@saravanan30erd please take a look on this and let me know your thoughts.
Thanks.

@saravanan30erd
Copy link
Collaborator

saravanan30erd commented Nov 2, 2021

@peterzhuamazon sure, I can update version 1.1.0 and will raise PR.

But I think creating long live branches such as 1.x, 2.x for managing the versions is a bit complex solution because it will become very difficult to manage many branches in future.

I think we should use github Releases & Tags feature to manage multiple versions.

We can use the same release version of the product, and use main branch as unstable branch with all new changes.
Example: current playbook deploys opensearch & dashboard 1.0.1 version so we can create a release with version 1.0.1.
Same for next versions.

Let me know your feedback.

@peterzhuamazon
Copy link
Member Author

Is there a playbook version vs app(opensearch) version in Ansible Playbook?
If you check our helm charts repo it is releasing a new charts version every PR, but the App Version stays with the OpenSearch version.

Also, we just release documentations for Ansible: https://opensearch.org/docs/latest/opensearch/install/ansible/
Let me know if you think we need to improve this.
If so, you can send PRs to https://github.com/opensearch-project/documentation-website.

Thanks.

@peterzhuamazon peterzhuamazon linked a pull request Nov 3, 2021 that will close this issue
1 task
@saravanan30erd
Copy link
Collaborator

saravanan30erd commented Nov 3, 2021

@peterzhuamazon
Is there a playbook version vs app(opensearch) version in Ansible Playbook?
No. Unlike Helm charts, Ansible playbooks doesn't have versioning feature as in-built so we need to manage the playbook version outside. so I think its better to match the opensearch version for playbook releases.

@peterzhuamazon
Copy link
Member Author

@peterzhuamazon Is there a playbook version vs app(opensearch) version in Ansible Playbook? No. Unlike Helm charts, Ansible playbooks doesn't have versioning feature as in-built so we need to manage the playbook version outside. so I think its better to match the opensearch version for playbook releases.

I can release 1.0.1 before merging this PR tho, do you find the current state stable for cutting a tag?

Thanks.

@saravanan30erd
Copy link
Collaborator

saravanan30erd commented Nov 4, 2021

@peterzhuamazon Yes, current main branch is working fine for version 1.0.1.
After merging this PR, you can create release for 1.1.0. I am planning to add multi-node cluster installation soon which I will start in 1.1.0.

@peterzhuamazon
Copy link
Member Author

Thanks. Release 1.0.1 now and will ask others to approve 1.1.0 as well.
To make things easy I think we will keep this main branch rolling with 1.1.0 until 1.2.0 release, then we cut tag for 1.1.0.
Thoughts?

@saravanan30erd
Copy link
Collaborator

saravanan30erd commented Nov 4, 2021

To make things easy I think we will keep this main branch rolling with 1.1.0 until 1.2.0 release, then we cut tag for 1.1.0. Thoughts?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants