now publishes a list of findings instead of an individual one (#1860)

* now publishes a list of findings instead of an individual one

Signed-off-by: Dennis Toepker <[email protected]>

* publish batch findings method

Signed-off-by: Dennis Toepker <[email protected]>

* adding success and failure logs when publishing findings

Signed-off-by: Dennis Toepker <[email protected]>

* reverting name change and replaced info with debug log

Signed-off-by: Dennis Toepker <[email protected]>

* more logging polishing

Signed-off-by: Dennis Toepker <[email protected]>

---------

Signed-off-by: Dennis Toepker <[email protected]>
Co-authored-by: Dennis Toepker <[email protected]>

Author: toepkerd

alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportDocLevelMonitorFanOutAction.kt

@@ -74,6 +74,7 @@ import org.opensearch.commons.alerting.AlertingPluginInterface
 import org.opensearch.commons.alerting.action.DocLevelMonitorFanOutAction
 import org.opensearch.commons.alerting.action.DocLevelMonitorFanOutRequest
 import org.opensearch.commons.alerting.action.DocLevelMonitorFanOutResponse
+import org.opensearch.commons.alerting.action.PublishBatchFindingsRequest
 import org.opensearch.commons.alerting.action.PublishFindingsRequest
 import org.opensearch.commons.alerting.action.SubscribeFindingsResponse
 import org.opensearch.commons.alerting.model.ActionExecutionResult
@@ -614,9 +615,7 @@ class TransportDocLevelMonitorFanOutAction
 
         if (monitor.shouldCreateSingleAlertForFindings == null || monitor.shouldCreateSingleAlertForFindings == false) {
             try {
-                findings.forEach { finding ->
-                    publishFinding(monitor, finding)
-                }
+                publishBatchFindings(monitor, findings)
             } catch (e: Exception) {
                 // suppress exception
                 log.error("Optional finding callback failed", e)
@@ -664,6 +663,27 @@ class TransportDocLevelMonitorFanOutAction
         )
     }
 
+    private fun publishBatchFindings(
+        monitor: Monitor,
+        findings: List<Finding>
+    ) {
+        val publishBatchFindingsRequest = PublishBatchFindingsRequest(monitor.id, findings)
+        log.debug("publishing {} findings from node {}", findings.size, clusterService.localNode().id)
+        AlertingPluginInterface.publishBatchFindings(
+            client as NodeClient,
+            publishBatchFindingsRequest,
+            object : ActionListener<SubscribeFindingsResponse> {
+                override fun onResponse(response: SubscribeFindingsResponse) {
+                    log.debug("findings published successfully")
+                }
+
+                override fun onFailure(e: Exception) {
+                    log.error("publishing findings failed", e)
+                }
+            }
+        )
+    }
+
     suspend fun runAction(
         action: Action,
         ctx: TriggerExecutionContext,