Skip to content

[Cleanup] Remove the upgrade-cli tool #18390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msfroh opened this issue May 28, 2025 · 4 comments
Open

[Cleanup] Remove the upgrade-cli tool #18390

msfroh opened this issue May 28, 2025 · 4 comments
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Other untriaged

Comments

@msfroh
Copy link
Contributor

msfroh commented May 28, 2025

Is your feature request related to a problem? Please describe

See the parent issue for details.

Describe the solution you'd like

Essentially, I think we just need to delete the distribution/tools/upgrade-cli directory. It may be referenced in some Gradle files that need to be cleaned up too.

Related component

Other

Describe alternatives you've considered

No response

Additional context

No response

@msfroh msfroh added enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers untriaged labels May 28, 2025
@github-actions github-actions bot added the Other label May 28, 2025
@andrross
Copy link
Member

Also distribution/src/bin/opensearch-upgrade[.bat], both of which can be deleted as well.

% git grep 'upgrade-cli'
.github/dependabot.yml:  - directory: /distribution/tools/upgrade-cli/
distribution/build.gradle:    libsUpgradeCli project(path: ':distribution:tools:upgrade-cli')
distribution/build.gradle:        into('tools/upgrade-cli') {
distribution/src/bin/opensearch-upgrade:  OPENSEARCH_ADDITIONAL_CLASSPATH_DIRECTORIES=lib/tools/upgrade-cli \
Binary file distribution/src/bin/opensearch-upgrade.bat matches
distribution/tools/upgrade-cli/build.gradle:  archivesName = 'opensearch-upgrade-cli'
settings.gradle:  'distribution:tools:upgrade-cli',

@peternied
Copy link
Member

@msfroh Thanks for creating this - looks save to remove. Didn't see any dangling references elsewhere in the project that need to be updated. I only see refs to build manifests where this was included.

@peternied
Copy link
Member

peternied commented May 29, 2025

@andrross
Copy link
Member

@peternied I don't believe that "update-to" section is still accessible. It seems to redirect to the migration assistant now:

https://github.com/opensearch-project/documentation-website/blob/158d1758d2fc397d3e97a467346a9320f4463e61/_migration-assistant/index.md?plain=1#L11-L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Other untriaged
Projects
None yet
Development

No branches or pull requests

3 participants