Address review comments

Signed-off-by: sukriti sinha <[email protected]>

Author: sukriti sinha

gradle/run.gradle

@@ -11,8 +11,7 @@
 
 /*
  * Licensed to Elasticsearch under one or more contributor
- * license agreements. See the 
- NOTICE file distributed with
+ * license agreements. See the NOTICE file distributed with
  * this work for additional information regarding copyright
  * ownership. Elasticsearch licenses this file to you under
  * the Apache License, Version 2.0 (the "License"); you may
@@ -40,17 +39,6 @@ testClusters {
     testDistribution = 'archive'
     if (numZones > 1) numberOfZones = numZones
     if (numNodes > 1) numberOfNodes = numNodes
-     setting 'node.attr.remote_store.segment.repository', 'my-repository'
-    setting 'node.attr.remote_store.translog.repository', 'my-repository'
-    setting 'node.attr.remote_store.state.repository', 'my-repository'
-    setting 'node.attr.remote_store.repository.my-repository.type', 'fs'
-    setting 'path.repo', '/Users/sukriiti/remote-store-data'
-    setting 'node.attr.remote_store.repository.my-repository.settings.location', '/Users/sukriiti/remote-store-data'
-    // setting 'opensearch.experimental.feature.tiered_remote_index.enabled', 'true'
-//    setting 'opensearch.experimental.feature.pluggable.caching.enabled', 'true'
-    setting 'node.search.cache.size', '10gb'
-    setting 'node.roles', 'ingest,remote_cluster_client,data,cluster_manager'
-    
     if (findProperty("installedPlugins")) {
       installedPlugins = Eval.me(installedPlugins)
       for (String p : installedPlugins) {

server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreMetadataIT.java

@@ -8,11 +8,10 @@
 
 package org.opensearch.action.admin.cluster.remotestore.metadata;
 
-import org.opensearch.common.annotation.PublicApi;
+import org.opensearch.common.annotation.ExperimentalApi;
 import org.opensearch.core.common.io.stream.StreamInput;
 import org.opensearch.core.common.io.stream.StreamOutput;
 import org.opensearch.core.common.io.stream.Writeable;
-import org.opensearch.core.xcontent.ToXContent.Params;
 import org.opensearch.core.xcontent.ToXContentFragment;
 import org.opensearch.core.xcontent.XContentBuilder;
 
@@ -24,7 +23,7 @@
  *
  * @opensearch.internal
  */
-@PublicApi(since = "3.0.0")
+@ExperimentalApi
 public class RemoteStoreMetadata implements Writeable, ToXContentFragment {
     private final Map<String, Object> segments;
     private final Map<String, Object> translog;
@@ -87,4 +86,12 @@ public String getIndexName() {
     public int getShardId() {
         return shardId;
     }
+
+    public Map<String, Object> getSegments() {
+        return segments;
+    }
+
+    public Map<String, Object> getTranslog() {
+        return translog;
+    }
 }

server/src/main/java/org/opensearch/action/admin/cluster/remotestore/metadata/RemoteStoreMetadata.java

@@ -9,21 +9,20 @@
 package org.opensearch.action.admin.cluster.remotestore.metadata;
 
 import org.opensearch.action.support.broadcast.BroadcastRequest;
-import org.opensearch.common.annotation.PublicApi;
+import org.opensearch.common.annotation.ExperimentalApi;
 import org.opensearch.core.common.io.stream.StreamInput;
 import org.opensearch.core.common.io.stream.StreamOutput;
 
 import java.io.IOException;
 
 /**
- * Request object for fetching remote store metadata of shards for a given index.
+ * Request object for fetching remote store metadata of shards across one or more indices.
  *
  * @opensearch.internal
  */
-@PublicApi(since = "3.0.0")
+@ExperimentalApi
 public class RemoteStoreMetadataRequest extends BroadcastRequest<RemoteStoreMetadataRequest> {
     private String[] shards;
-    private boolean local = false;
 
     public RemoteStoreMetadataRequest() {
         super((String[]) null);
@@ -33,14 +32,12 @@ public RemoteStoreMetadataRequest() {
     public RemoteStoreMetadataRequest(StreamInput in) throws IOException {
         super(in);
         shards = in.readStringArray();
-        local = in.readBoolean();
     }
 
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         super.writeTo(out);
         out.writeStringArray(shards);
-        out.writeBoolean(local);
     }
 
     public RemoteStoreMetadataRequest shards(String... shards) {
@@ -51,12 +48,4 @@ public RemoteStoreMetadataRequest shards(String... shards) {
     public String[] shards() {
         return this.shards;
     }
-
-    public void local(boolean local) {
-        this.local = local;
-    }
-
-    public boolean local() {
-        return local;
-    }
 }

server/src/main/java/org/opensearch/action/admin/cluster/remotestore/metadata/RemoteStoreMetadataRequest.java

@@ -9,7 +9,7 @@
 package org.opensearch.action.admin.cluster.remotestore.metadata;
 
 import org.opensearch.action.support.broadcast.BroadcastOperationRequestBuilder;
-import org.opensearch.common.annotation.PublicApi;
+import org.opensearch.common.annotation.ExperimentalApi;
 import org.opensearch.common.unit.TimeValue;
 import org.opensearch.transport.client.OpenSearchClient;
 
@@ -18,7 +18,7 @@
  *
  * @opensearch.api
  */
-@PublicApi(since = "3.0.0")
+@ExperimentalApi
 public class RemoteStoreMetadataRequestBuilder extends BroadcastOperationRequestBuilder<
     RemoteStoreMetadataRequest,
     RemoteStoreMetadataResponse,
@@ -43,12 +43,4 @@ public final RemoteStoreMetadataRequestBuilder setShards(String... shards) {
         request.shards(shards);
         return this;
     }
-
-    /**
-     * Sets local shards preference of request.
-     */
-    public final RemoteStoreMetadataRequestBuilder setLocal(boolean local) {
-        request.local(local);
-        return this;
-    }
 }

server/src/main/java/org/opensearch/action/admin/cluster/remotestore/metadata/RemoteStoreMetadataRequestBuilder.java

@@ -9,7 +9,7 @@
 package org.opensearch.action.admin.cluster.remotestore.metadata;
 
 import org.opensearch.action.support.broadcast.BroadcastResponse;
-import org.opensearch.common.annotation.PublicApi;
+import org.opensearch.common.annotation.ExperimentalApi;
 import org.opensearch.core.action.support.DefaultShardOperationFailedException;
 import org.opensearch.core.common.Strings;
 import org.opensearch.core.common.io.stream.StreamInput;
@@ -28,7 +28,7 @@
  *
  * @opensearch.api
  */
-@PublicApi(since = "3.0.0")
+@ExperimentalApi
 public class RemoteStoreMetadataResponse extends BroadcastResponse {
     private final RemoteStoreMetadata[] remoteStoreMetadata;