addressing comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

Author: sarthakaggarwal97

server/src/main/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducerWrapper.java

@@ -10,7 +10,6 @@
 
 import org.apache.lucene.codecs.DocValuesProducer;
 import org.apache.lucene.index.SegmentReadState;
-import org.apache.lucene.index.SortedNumericDocValues;
 import org.opensearch.index.codec.composite.CompositeDocValuesProducer;
 
 import java.io.IOException;
@@ -25,7 +24,6 @@
 public class Lucene90DocValuesProducerWrapper implements CompositeDocValuesProducer {
 
     private final Lucene90DocValuesProducer lucene90DocValuesProducer;
-    private final SegmentReadState state;
 
     public Lucene90DocValuesProducerWrapper(
         SegmentReadState state,
@@ -35,13 +33,6 @@ public Lucene90DocValuesProducerWrapper(
         String metaExtension
     ) throws IOException {
         lucene90DocValuesProducer = new Lucene90DocValuesProducer(state, dataCodec, dataExtension, metaCodec, metaExtension);
-        this.state = state;
-    }
-
-    // returns the field doc id set iterator based on field name
-    @Override
-    public SortedNumericDocValues getSortedNumeric(String fieldName) throws IOException {
-        return this.lucene90DocValuesProducer.getSortedNumeric(state.fieldInfos.fieldInfo(fieldName));
     }
 
     @Override

server/src/main/java/org/opensearch/index/codec/composite/CompositeDocValuesProducer.java

@@ -9,10 +9,8 @@
 package org.opensearch.index.codec.composite;
 
 import org.apache.lucene.codecs.DocValuesProducer;
-import org.apache.lucene.index.SortedNumericDocValues;
 
 import java.io.Closeable;
-import java.io.IOException;
 
 /**
  * An interface that provides access to document values for a specific field.
@@ -21,15 +19,6 @@
  */
 public interface CompositeDocValuesProducer extends Closeable {
 
-    /**
-     * Returns the sorted numeric document values for the specified field.
-     *
-     * @param fieldName The name of the field for which to retrieve the sorted numeric document values.
-     * @return The sorted numeric document values for the specified field.
-     * @throws IOException If an error occurs while retrieving the sorted numeric document values.
-     */
-    SortedNumericDocValues getSortedNumeric(String fieldName) throws IOException;
-
     /**
      * Returns the DocValuesProducer instance.
      *

server/src/main/java/org/opensearch/index/codec/composite/LuceneDocValuesConsumerFactory.java

@@ -23,22 +23,15 @@
 public class LuceneDocValuesConsumerFactory {
 
     public static DocValuesConsumer getDocValuesConsumerForCompositeCodec(
-        String compositeCodec,
         SegmentWriteState state,
         String dataCodec,
         String dataExtension,
         String metaCodec,
         String metaExtension
     ) throws IOException {
 
-        switch (compositeCodec) {
-            case CompositeCodecFactory.COMPOSITE_CODEC:
-                return new Lucene90DocValuesConsumerWrapper(state, dataCodec, dataExtension, metaCodec, metaExtension)
-                    .getLucene90DocValuesConsumer();
-            default:
-                throw new IllegalStateException("Invalid composite codec " + "[" + compositeCodec + "]");
-        }
-
+        return new Lucene90DocValuesConsumerWrapper(state, dataCodec, dataExtension, metaCodec, metaExtension)
+            .getLucene90DocValuesConsumer();
     }
 
 }

server/src/test/java/org/opensearch/index/codec/composite/LuceneDocValuesConsumerFactoryTests.java

@@ -17,6 +17,7 @@
 import org.apache.lucene.store.Directory;
 import org.apache.lucene.util.InfoStream;
 import org.apache.lucene.util.Version;
+import org.opensearch.index.codec.composite.composite99.Composite99Codec;
 import org.opensearch.test.OpenSearchTestCase;
 import org.junit.After;
 import org.junit.Before;
@@ -26,9 +27,6 @@
 import java.util.HashMap;
 import java.util.UUID;
 
-import static org.opensearch.index.codec.composite.composite99.Composite99Codec.COMPOSITE_INDEX_CODEC_NAME;
-import static org.mockito.Mockito.mock;
-
 public class LuceneDocValuesConsumerFactoryTests extends OpenSearchTestCase {
 
     private Directory directory;
@@ -67,7 +65,6 @@ public void testGetDocValuesConsumerForCompositeCodec() throws IOException {
         );
 
         DocValuesConsumer consumer = LuceneDocValuesConsumerFactory.getDocValuesConsumerForCompositeCodec(
-            COMPOSITE_INDEX_CODEC_NAME,
             state,
             dataCodec,
             dataExtension,
@@ -76,26 +73,10 @@ public void testGetDocValuesConsumerForCompositeCodec() throws IOException {
         );
 
         assertEquals("org.apache.lucene.codecs.lucene90.Lucene90DocValuesConsumer", consumer.getClass().getName());
+        assertEquals(CompositeCodecFactory.COMPOSITE_CODEC, Composite99Codec.COMPOSITE_INDEX_CODEC_NAME);
         consumer.close();
     }
 
-    public void testGetDocValuesConsumerForCompositeCodec_InvalidCodec() {
-        String compositeCodec = "invalid_codec";
-        SegmentWriteState state = mock(SegmentWriteState.class);
-
-        IllegalStateException exception = expectThrows(IllegalStateException.class, () -> {
-            LuceneDocValuesConsumerFactory.getDocValuesConsumerForCompositeCodec(
-                compositeCodec,
-                state,
-                dataCodec,
-                dataExtension,
-                metaCodec,
-                metaExtension
-            );
-        });
-        assertTrue(exception.getMessage().contains("Invalid composite codec"));
-    }
-
     @After
     public void teardown() throws Exception {
         super.tearDown();

server/src/test/java/org/opensearch/index/codec/composite/LuceneDocValuesProducerFactoryTests.java

@@ -28,7 +28,6 @@
 import java.util.HashMap;
 import java.util.UUID;
 
-import static org.opensearch.index.codec.composite.composite99.Composite99Codec.COMPOSITE_INDEX_CODEC_NAME;
 import static org.mockito.Mockito.mock;
 
 public class LuceneDocValuesProducerFactoryTests extends OpenSearchTestCase {
@@ -70,7 +69,6 @@ public void testGetDocValuesProducerForCompositeCodec99() throws IOException {
             newIOContext(random())
         );
         DocValuesConsumer consumer = LuceneDocValuesConsumerFactory.getDocValuesConsumerForCompositeCodec(
-            COMPOSITE_INDEX_CODEC_NAME,
             state,
             dataCodec,
             dataExtension,