Skip to content

Commit 20e56f1

Browse files
committed
address comments
Signed-off-by: Ruirui Zhang <[email protected]>
1 parent dc8a8f6 commit 20e56f1

File tree

4 files changed

+57
-69
lines changed

4 files changed

+57
-69
lines changed

server/src/main/java/org/opensearch/common/settings/ClusterSettings.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@
159159
import org.opensearch.search.backpressure.settings.SearchShardTaskSettings;
160160
import org.opensearch.search.backpressure.settings.SearchTaskSettings;
161161
import org.opensearch.search.fetch.subphase.highlight.FastVectorHighlighter;
162-
import org.opensearch.search.query_group.QueryGroupServiceSettings;
163162
import org.opensearch.snapshots.InternalSnapshotsInfoService;
164163
import org.opensearch.snapshots.SnapshotsService;
165164
import org.opensearch.tasks.TaskCancellationMonitoringSettings;
@@ -174,6 +173,7 @@
174173
import org.opensearch.transport.SniffConnectionStrategy;
175174
import org.opensearch.transport.TransportSettings;
176175
import org.opensearch.watcher.ResourceWatcherService;
176+
import org.opensearch.wlm.WorkloadManagementSettings;
177177

178178
import java.util.Arrays;
179179
import java.util.Collections;
@@ -769,11 +769,11 @@ public void apply(Settings value, Settings current, Settings previous) {
769769

770770
SystemTemplatesService.SETTING_APPLICATION_BASED_CONFIGURATION_TEMPLATES_ENABLED,
771771

772-
// QueryGroup settings
773-
QueryGroupServiceSettings.NODE_LEVEL_CPU_REJECTION_THRESHOLD,
774-
QueryGroupServiceSettings.NODE_LEVEL_CPU_CANCELLATION_THRESHOLD,
775-
QueryGroupServiceSettings.NODE_LEVEL_MEMORY_REJECTION_THRESHOLD,
776-
QueryGroupServiceSettings.NODE_LEVEL_MEMORY_CANCELLATION_THRESHOLD
772+
// WorkloadManagement settings
773+
WorkloadManagementSettings.NODE_LEVEL_CPU_REJECTION_THRESHOLD,
774+
WorkloadManagementSettings.NODE_LEVEL_CPU_CANCELLATION_THRESHOLD,
775+
WorkloadManagementSettings.NODE_LEVEL_MEMORY_REJECTION_THRESHOLD,
776+
WorkloadManagementSettings.NODE_LEVEL_MEMORY_CANCELLATION_THRESHOLD
777777
)
778778
)
779779
);

server/src/main/java/org/opensearch/search/query_group/package-info.java

Lines changed: 0 additions & 12 deletions
This file was deleted.

server/src/main/java/org/opensearch/search/query_group/QueryGroupServiceSettings.java renamed to server/src/main/java/org/opensearch/wlm/WorkloadManagementSettings.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* compatible open source license.
77
*/
88

9-
package org.opensearch.search.query_group;
9+
package org.opensearch.wlm;
1010

1111
import org.opensearch.common.settings.ClusterSettings;
1212
import org.opensearch.common.settings.Setting;
@@ -15,7 +15,7 @@
1515
/**
1616
* Main class to declare the QueryGroup feature related settings
1717
*/
18-
public class QueryGroupServiceSettings {
18+
public class WorkloadManagementSettings {
1919
private static final Double DEFAULT_NODE_LEVEL_MEMORY_REJECTION_THRESHOLD = 0.8;
2020
private static final Double DEFAULT_NODE_LEVEL_MEMORY_CANCELLATION_THRESHOLD = 0.9;
2121
private static final Double DEFAULT_NODE_LEVEL_CPU_REJECTION_THRESHOLD = 0.8;
@@ -88,7 +88,7 @@ public class QueryGroupServiceSettings {
8888
* @param settings - QueryGroup service settings
8989
* @param clusterSettings - QueryGroup cluster settings
9090
*/
91-
public QueryGroupServiceSettings(Settings settings, ClusterSettings clusterSettings) {
91+
public WorkloadManagementSettings(Settings settings, ClusterSettings clusterSettings) {
9292
nodeLevelMemoryCancellationThreshold = NODE_LEVEL_MEMORY_CANCELLATION_THRESHOLD.get(settings);
9393
nodeLevelMemoryRejectionThreshold = NODE_LEVEL_MEMORY_REJECTION_THRESHOLD.get(settings);
9494
nodeLevelCpuCancellationThreshold = NODE_LEVEL_CPU_CANCELLATION_THRESHOLD.get(settings);

0 commit comments

Comments
 (0)