addressing comments

bharath-techie · bharath-techie · commit 1052eadb9333 · 2024-08-19T20:26:46.000+05:30
Signed-off-by: Bharathwaj G &lt;bharath78910@gmail.com&gt;
diff --git a/server/src/main/java/org/opensearch/index/mapper/StarTreeMapper.java b/server/src/main/java/org/opensearch/index/mapper/StarTreeMapper.java
@@ -285,7 +285,7 @@ private void addBaseMetrics(MetricStat metricStat, Set<MetricStat> metricSet) {
                 Queue<MetricStat> metricQueue = new LinkedList<>(metricStat.getBaseMetrics());
                 while (metricQueue.isEmpty() == false) {
                     MetricStat metric = metricQueue.poll();
-                    if (metric.isDerivedMetric()) {
+                    if (metric.isDerivedMetric() && !metricSet.contains(metric)) {
                         metricQueue.addAll(metric.getBaseMetrics());
                     }
                     metricSet.add(metric);

Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,7 @@ private void addBaseMetrics(MetricStat metricStat, Set<MetricStat> metricSet) {`
`285`	`285`	`Queue<MetricStat> metricQueue = new LinkedList<>(metricStat.getBaseMetrics());`
`286`	`286`	`while (metricQueue.isEmpty() == false) {`
`287`	`287`	`MetricStat metric = metricQueue.poll();`
`288`		`- if (metric.isDerivedMetric()) {`
	`288`	`+ if (metric.isDerivedMetric() && !metricSet.contains(metric)) {`
`289`	`289`	`metricQueue.addAll(metric.getBaseMetrics());`
`290`	`290`	`}`
`291`	`291`	`metricSet.add(metric);`