Skip to content

[Workspace] How to handle with global object across workspace #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SuZhou-Joe opened this issue Apr 3, 2024 · 0 comments
Closed

[Workspace] How to handle with global object across workspace #6325

SuZhou-Joe opened this issue Apr 3, 2024 · 0 comments
Labels
enhancement New feature or request untriaged

Comments

@SuZhou-Joe
Copy link
Member

SuZhou-Joe commented Apr 3, 2024

Is your feature request related to a problem? Please describe.

We are introducing workspace to manage saved objects and enhance them with permission control. But there are some objects supposed to only exist out of workspace. Advanced settings for example, under the hood it is a saved object whose id consist of config:${OSDVersion} and stands for application settings for the entire OSD.

But as we are introducing workspace, and workspace will regard all saved objects as workspace objects by default, which means those "global objects" will be created inside a workspace accidentally. And it will break some features, for example, if the advanced settings is created accidentally inside a workspace foo, and the owner of the workspace someday decide to delete the workspace, all the related objects inside the workspace, including the advanced settings, will be deleted as well.

Describe the solution you'd like

Option A: Prevent user from visiting global-objects-related pages in browser side.

description: We can limit user from visiting the related pages and thus user is not able to create those objects inside workspace by using OSD Web UI.
pros:

  • Less effort to implement
    cons:
  • User can still create the objects by calling OSD APIs.

Option B: Prevent user from creating global objects in server side.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@SuZhou-Joe SuZhou-Joe added the enhancement New feature or request label Apr 3, 2024
@SuZhou-Joe SuZhou-Joe closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

No branches or pull requests

1 participant